Merge pull request #111 from Ostorlab/feature/Update-template-of-timi…

…ng-arg-to-be-T5

Update template of timing arg to be T5

ostorlab.yaml

@@ -106,7 +106,7 @@ args:
   - name: "timing_template"
     type: "string"
     description: "Template of timing settings (T0, T1, ... T5)."
-    value: "T3"
+    value: "T5"
   - name: "script_default"
     type: "boolean"
     description: "Script scan, equivalent to --script=default"

tests/nmap_agent_test.py

@@ -474,7 +474,7 @@ def testAgentNmapOptions_whenUrlsScriptsGivent_RunScan(
 
     assert all(
         a in options.command_options
-        for a in ["-sV", "-n", "-p", "0-65535", "-T3", "-sS", "-Pn", "--script"]
+        for a in ["-sV", "-n", "-p", "0-65535", "-T5", "-sS", "-Pn", "--script"]
     )
 
 
@@ -511,7 +511,7 @@ def testAgentNmapOptions_whenUrlsScriptsGivent_RunScan2(
 
     assert all(
         a in options.command_options
-        for a in ["-sV", "-n", "-p", "0-65535", "-T3", "-sS", "-Pn", "--script"]
+        for a in ["-sV", "-n", "-p", "0-65535", "-T5", "-sS", "-Pn", "--script"]
     )
 
 

tests/nmap_wrapper_test.py

@@ -35,7 +35,7 @@ def testNmapWrapper_whenFastMode_returnCommand(
         "-sV",
         "-n",
         "-F",
-        "-T3",
+        "-T5",
         "-sS",
         "--script",
         "banner",
@@ -74,7 +74,7 @@ def testNmapWrapper_whenTopPortsUsed_returnCommand(
         "-n",
         "--top-ports",
         "420",
-        "-T3",
+        "-T5",
         "-sS",
         "--script",
         "banner",
@@ -113,7 +113,7 @@ def testNmapWrapper_whenAllTopPortsUsed_returnCommand(
         "-n",
         "-p",
         "0-65535",
-        "-T3",
+        "-T5",
         "-sS",
         "--script",
         "banner",
@@ -217,7 +217,7 @@ def testNmapWrapper_whenTcpSynPingPortsIsUsed_returnCommand(
         "-sV",
         "-n",
         "-F",
-        "-T3",
+        "-T5",
         "-sS",
         "-PS21,22,25,53,68,80,110,123,143,443,465,631,993,995,3306,3389,8080",
         "--script",