Merge pull request #97 from Ostorlab/fix/swtich_syn_all_port

Change default to all ports with SYN scan.

agent/nmap_options.py

@@ -55,7 +55,7 @@ class NmapOptions:
     version_detection: bool = True
     port_scanning_techniques: List[PortScanningTechnique] = dataclasses.field(
         default_factory=lambda: [
-            PortScanningTechnique.TCP_CONNECT,
+            PortScanningTechnique.TCP_SYN,
         ]
     )
     no_ping: bool = True

ostorlab.yaml

@@ -83,7 +83,7 @@ args:
   - name: "fast_mode"
     description: "Fast mode scans fewer ports than the default mode."
     type: "boolean"
-    value: true
+    value: false
   - name: "ports"
     type: "string"
     description: "List of ports to scan."

tests/nmap_agent_test.py

@@ -322,7 +322,7 @@ def testAgentNmapOptions_whenUrlsScriptsGivent_RunScan(
 
     assert all(
         a in options.command_options
-        for a in ["-sV", "-n", "-p", "0-65535", "-T3", "-sT", "-Pn", "--script"]
+        for a in ["-sV", "-n", "-p", "0-65535", "-T3", "-sS", "-Pn", "--script"]
     )
 
 
@@ -359,7 +359,7 @@ def testAgentNmapOptions_whenUrlsScriptsGivent_RunScan2(
 
     assert all(
         a in options.command_options
-        for a in ["-sV", "-n", "-p", "0-65535", "-T3", "-sT", "-Pn", "--script"]
+        for a in ["-sV", "-n", "-p", "0-65535", "-T3", "-sS", "-Pn", "--script"]
     )
 
 

tests/nmap_wrapper_test.py

@@ -35,7 +35,7 @@ def testNmapWrapper_whenFastMode_returnCommand(
         "-n",
         "-F",
         "-T3",
-        "-sT",
+        "-sS",
         "--script",
         "banner",
         "-sC",
@@ -73,7 +73,7 @@ def testNmapWrapper_whenTopPortsUsed_returnCommand(
         "--top-ports",
         "420",
         "-T3",
-        "-sT",
+        "-sS",
         "--script",
         "banner",
         "-sC",
@@ -111,7 +111,7 @@ def testNmapWrapper_whenAllTopPortsUsed_returnCommand(
         "-p",
         "0-65535",
         "-T3",
-        "-sT",
+        "-sS",
         "--script",
         "banner",
         "-sC",