Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pymetasploit3 #5

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Feature/pymetasploit3 #5

merged 9 commits into from
Nov 1, 2023

Conversation

BlueSquare1
Copy link
Contributor

No description provided.

@3asm
Copy link
Member

3asm commented Oct 28, 2023

Please split PR to add mymeta only.

.mypy.ini Outdated
@@ -17,7 +17,9 @@ warn_incomplete_stub = True
warn_redundant_casts = True
#warn_unreachable = True
warn_unused_ignores = True
disallow_any_unimported = True
disallow_any_unimported = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Dockerfile Outdated
COPY --from=builder /install /usr/local
RUN python3 -m pip install -r /requirement.txt
COPY tools /tools
RUN pip install -e /tools/pymetasploit3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a package vs. just adding the code and importing it?

@@ -0,0 +1,194 @@
"""Ostorlab Agent implementation for metasploit"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code should not be in this PR.

agent/utils.py Outdated
@@ -0,0 +1,15 @@
"""Utilities for agent Metasploit"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR.

ostorlab.yaml Outdated
out_selectors: [] # List of output selectors.
docker_file_path : Dockerfile # Dockerfile path for automated releases.
docker_build_root : . # Docker build dir for automated release build.
name: metasploit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR.

@BlueSquare1 BlueSquare1 changed the base branch from main to agent_core October 31, 2023 09:50
@BlueSquare1 BlueSquare1 merged commit 71a8147 into agent_core Nov 1, 2023
2 checks passed
@BlueSquare1 BlueSquare1 deleted the feature/pymetasploit3 branch November 3, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants