Agent Metasploit #4

BlueSquare1 · 2023-10-27T09:30:35Z

Running the following scan:

kind: AgentGroup
description: Metasploit.
agents:
  - key: agent//metasploit
    args:
      - name: config
        type: array
        value: 
          - module: 'auxiliary/scanner/portscan/tcp'
            options:
              - name: "PORTS"
                value: "80,443"

Results:

Note:

The risk rating defaults to High because we're using metasploit with CISA exploits for now.

- Set WORKSPACE to Ostorlab

mohsinenar · 2023-10-27T12:35:57Z

.mypy.ini

@@ -17,7 +17,9 @@ warn_incomplete_stub = True
 warn_redundant_casts = True
 #warn_unreachable = True
 warn_unused_ignores = True
-disallow_any_unimported = True
+disallow_any_unimported = False


it's raising errors because of pymetasploit3 local module

How hard would it be to add typing there?

I don't think it has much value right now given the 90+ pending exploits we have.

@BlueSquare1 you can ignore pymetasploit3 without ignoring everything.

Dockerfile

agent/metasploit_agent.py

agent/utils.py

tests/conftest.py

.mypy.ini

agent/metasploit_agent.py

…t_core # Conflicts: # tools/pymetasploit3/tests/test_db.py

elyousfi5

Please use python3.11 :D

agent/metasploit_agent.py

tests/metasploit_agent_test.py

- Unit tests for prepare_target

Msfrpc patch

- Update README

3asm · 2023-11-08T12:45:28Z

As discussed, add support for running multiple modules.

3asm · 2023-11-09T11:32:25Z

Please update the description.

3asm · 2023-11-09T11:33:04Z

.mypy.ini

@@ -17,7 +17,9 @@ warn_incomplete_stub = True
 warn_redundant_casts = True
 #warn_unreachable = True
 warn_unused_ignores = True
-disallow_any_unimported = True
+disallow_any_unimported = False


How hard would it be to add typing there?

3asm · 2023-11-09T11:34:08Z

ostorlab.yaml

+    - key: agent//metasploit
+      args:
+        - name: module
+          type: string
+          value: 'auxiliary/scanner/portscan/tcp'
+        - name: options
+          type: array
+          value:
+            - name: "PORTS"
+              value: "80, 443"
+  ```


Please correct.

requirement.txt

ostorlab added 7 commits October 27, 2023 10:28

Agent core.

cf5c359

Add pymetasploit3

dcc3115

- Fix check bug

78e6de2

- Set WORKSPACE to Ostorlab

Fix unit tests

0acffe2

- Black!

4579ef2

Update docstring

a6f7ae9

Optimize imports

bdc682e

mohsinenar requested changes Oct 27, 2023

View reviewed changes

Pass msf options as argument

3af5017

ErebusZ requested changes Oct 27, 2023

View reviewed changes

ostorlab added 2 commits October 30, 2023 08:57

Fix mypy

60af5c7

Black!

2744ea0

BlueSquare1 changed the base branch from main to pymetasploit_only October 31, 2023 10:08

3asm marked this pull request as draft October 31, 2023 18:36

Base automatically changed from pymetasploit_only to main October 31, 2023 18:41

ostorlab added 2 commits November 1, 2023 10:40

Merge remote-tracking branch 'origin/main' into agent_core

e7713c3

Merge remote-tracking branch 'origin/feature/pymetasploit3' into agen…

71a8147

…t_core # Conflicts: # tools/pymetasploit3/tests/test_db.py

BlueSquare1 marked this pull request as ready for review November 1, 2023 09:57

ostorlab added 4 commits November 1, 2023 11:33

use msfrpc init instead of fixture

3f3fd2a

use port 55552

a3e5da2

Kill previous instances of msfrpcd

41b22b6

Fix linting

faecf71

elyousfi5 reviewed Nov 1, 2023

View reviewed changes

ostorlab added 2 commits November 1, 2023 12:09

options type array

38d608f

Use metasploit module name for KB

2a8d5b3

PiranhaSa reviewed Nov 1, 2023

View reviewed changes

agent/metasploit_agent.py Outdated Show resolved Hide resolved

ErebusZ requested changes Nov 1, 2023

View reviewed changes

agent/metasploit_agent.py Outdated Show resolved Hide resolved

agent/metasploit_agent.py Outdated Show resolved Hide resolved

tests/metasploit_agent_test.py Outdated Show resolved Hide resolved

ostorlab added 3 commits November 1, 2023 15:47

docstring details

9803d50

- Use python3.11

ac27319

- Unit tests for prepare_target

- Test for IPv6

c88681a

ostorlab and others added 7 commits November 3, 2023 11:21

msfrpc tweaks

6314f00

Typing

1374c1d

Merge remote-tracking branch 'origin/agent_core' into msfrpc_patch

70faa35

Merge pull request #7 from Ostorlab/msfrpc_patch

1909396

Msfrpc patch

Remove arg

0933231

- Update agent

a9df478

- Update README

Fix linter

365b3a1

BlueSquare1 marked this pull request as draft November 3, 2023 14:39

ostorlab added 7 commits November 3, 2023 16:47

Use snap instead of apt

5f46418

Linter

fa2ecc4

Don't capture output

0c8191f

Skip test

7e84eb4

rollback

03305ac

use Popen instead of run

e142622

Run msfrpcd from pipeline

47cc4d8

BlueSquare1 marked this pull request as ready for review November 7, 2023 10:44

ostorlab added 4 commits November 7, 2023 12:04

- Use python3.11

2be6437

Use code block

3e245c2

Use code block

f7e0c67

use timeout decorator

c594ec9

ostorlab added 2 commits November 8, 2023 18:04

Support multiple modules

fcae758

Update docs

d8943c2

3asm requested changes Nov 9, 2023

View reviewed changes

ostorlab added 2 commits November 9, 2023 15:07

Remove timeout decorator

0e7249c

Update Ostorlab yaml

f8c10e4

3asm approved these changes Nov 9, 2023

View reviewed changes

3asm merged commit 1b252f4 into main Nov 9, 2023
2 checks passed

3asm deleted the agent_core branch November 9, 2023 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agent Metasploit #4

Agent Metasploit #4

BlueSquare1 commented Oct 27, 2023 •

edited

Loading

mohsinenar Oct 27, 2023

3asm Oct 28, 2023

BlueSquare1 Nov 1, 2023

3asm Nov 9, 2023

BlueSquare1 Nov 9, 2023

mohsinenar Nov 9, 2023

elyousfi5 left a comment

3asm commented Nov 8, 2023

3asm commented Nov 9, 2023

3asm Nov 9, 2023

3asm Nov 9, 2023

Agent Metasploit #4

Agent Metasploit #4

Conversation

BlueSquare1 commented Oct 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elyousfi5 left a comment

Choose a reason for hiding this comment

3asm commented Nov 8, 2023

3asm commented Nov 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BlueSquare1 commented Oct 27, 2023 •

edited

Loading