fix comments

Ostorlab · Nov 21, 2023 · d360d5d · d360d5d
1 parent be30259
commit d360d5d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -101,15 +101,3 @@ def check(self, target: definitions.Target) -> list[definitions.Vulnerability]:
 
     yield TestExploit
     exploits_registry.unregister(TestExploit)
-
-
-@pytest.fixture()
-def target_vulnerable_to_cve_2018_13382() -> definitions.Target:
-    """Creates a target vulnerable to CVE-2018-13382."""
-    return definitions.Target("https", "109.239.246.106", 10443)
-
-
-@pytest.fixture()
-def target_not_vulnerable_to_cve_2018_13382() -> definitions.Target:
-    """Creates a target vulnerable to CVE-2018-13382."""
-    return definitions.Target("https", "139.255.255.218", 10443)
diff --git a/tests/exploits_test.py b/tests/exploits_test.py
@@ -85,7 +85,6 @@ def testCVE_2021_22941_whenVulnerable_reportFinding(
 
 def test_CVE_2018_13382_whenVulnerable_reportFinding(
     requests_mock: req_mock.mocker.Mocker,
-    target_vulnerable_to_cve_2018_13382: definitions.Target,
 ) -> None:
     """Ensure that the exploit reports findings when the application is vulnerable."""
     exploit_instance = cve_2018_13382.CVE201813382Exploit()
@@ -96,7 +95,8 @@ def test_CVE_2018_13382_whenVulnerable_reportFinding(
         status_code=200,
     )
 
-    vulnerabilities = exploit_instance.check(target_vulnerable_to_cve_2018_13382)
+    target = definitions.Target("https", "109.239.246.106", 10443)
+    vulnerabilities = exploit_instance.check(target)
     vulnerability = vulnerabilities[0]
 
     assert (
@@ -111,7 +111,6 @@ def test_CVE_2018_13382_whenVulnerable_reportFinding(
 
 def test_CVE_2018_13382_whenNotVulnerable_reportFinding(
     requests_mock: req_mock.mocker.Mocker,
-    target_not_vulnerable_to_cve_2018_13382: definitions.Target,
 ) -> None:
     """Ensure that there is not findings when the application is not vulnerable."""
     exploit_instance = cve_2018_13382.CVE201813382Exploit()
@@ -122,6 +121,7 @@ def test_CVE_2018_13382_whenNotVulnerable_reportFinding(
         status_code=200,
     )
 
-    vulnerabilities = exploit_instance.check(target_not_vulnerable_to_cve_2018_13382)
+    target = definitions.Target("https", "139.255.255.218", 10443)
+    vulnerabilities = exploit_instance.check(target)
 
     assert len(vulnerabilities) == 0