Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

adds min and max config for continuous and instantaneous plots #29

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

vmora
Copy link
Contributor

@vmora vmora commented Jan 20, 2020

No description provided.

@vmora
Copy link
Contributor Author

vmora commented Jan 20, 2020

I see that plots are from from a position and interval, with albion I have a 'to_' and 'from_' column and it doesn't work, could we have an option for that ?

This branch kinda works, but I think there is a bug when adding new column, can you check that @mhugo before merging ? Thanks

@mhugo
Copy link
Contributor

mhugo commented Jan 21, 2020

I see that plots are from from a position and interval, with albion I have a 'to_' and 'from_' column and it doesn't work, could we have an option for that ?

Not sure to understand. Depth ranges of stratigraphic logs are defined by two fields "depth_from" and "depth_to", which seems to fit your usecase. For other kind of graphs, there are two storage modes (names are not well chosen):

  • "continuous" : data defined by continuous "blocks" with a start and an array of data
  • "instantaneous": data defined by one (x, y) value for each sample, which seems to fit your need here.

Did I miss something else ?

I'll have a look at your branch, thanks

@mhugo
Copy link
Contributor

mhugo commented Jan 21, 2020

I fixed a bug to make it work.

We should quickly add a way to update the configuration of a column !

@mhugo mhugo merged commit 7d40f1f into master Jan 21, 2020
@vmora
Copy link
Contributor Author

vmora commented Jan 22, 2020

Thanks a lot @mhugo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants