Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix master #6

Merged
merged 5 commits into from
Sep 5, 2019
Merged

Bug/fix master #6

merged 5 commits into from
Sep 5, 2019

Conversation

kitsbits
Copy link
Collaborator

@kitsbits kitsbits commented Sep 4, 2019

  • Branched off of master and fixed merge errors in the pxbproj file that was causing a build failure after the latest merge

  • FINALLY was able to properly link react-native-firebase (v6 their newest one)

  • I also needed to reconfigure the podfile because properly linking react-native-firebase was causing other problems with the way React and other foundational libraries were being installed as the app was built. I came across this in the React-Native docs but the package-linking was failing. So, I found various other versions on stack overflow and the like and finally landed on a combination of things I found here. (It was also helpful to delete ios/Pods and ios/build every once in a while after trying a bunch of pod installs.)

LOTS of trial and error, but it seems to be building okay AND I'm getting our words document logging in the console. Phew.

FYI, I needed to update my operating system AND xcode to get this all working properly, which was a pain and you may have to do this also, but I am not sure.

@kitsbits kitsbits requested a review from OshaFoster September 4, 2019 07:25
@kitsbits
Copy link
Collaborator Author

kitsbits commented Sep 4, 2019

Oh! And this does not include removing all of the files we don't want checked into master, so we'll still have to do that at some point.

@OshaFoster OshaFoster merged commit c992382 into master Sep 5, 2019
@OshaFoster OshaFoster deleted the bug/fix-master branch September 5, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants