-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boxr syntax highlighting #9
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the feedback! I shall move the syntaxes, and the comment is literally what comes out of the box in the demo project. |
@KamasamaK Is this a good guide to add the punctuation.definition stuff? I am not sure where to look for good resources. |
@cybersonic Yes, that is a good guide for scope naming, but the syntax for SublimeText grammars is a bit different from TextMate. You may also find some of the built-in TM grammars helpful (e.g. shellscript). |
Is this still in progress? @KamasamaK Can we merge what we have? |
I'm not familiar enough with the file format to say whether it's correct, so my issues with it were more general around standard practice for contributing languages. I haven't tested it, but from what I can tell it won't break anything that already exists and works, so if @cybersonic is unable to make those improvements it should still be fine and probably better than nothing. |
Yeah, I'd prefer to at least merge what we have even if it's not perfect and we can improve on it. I just don't' like pulls sitting forever :) |
Sooo, should this be merged now? It has sat for a long time @bdw429s @bdw429s ? Is it working @cybersonic |
Keeping up to date
Looking at the changes that @KamasamaK requested. Will update the PR |
Do we have anything else in order to merge this @cybersonic @KamasamaK |
This is my initial pass at syntax highlighting for boxr.
see: #8