Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): connection cleanup on max attempts #97

Merged
merged 2 commits into from
Sep 23, 2019
Merged

feat(client): connection cleanup on max attempts #97

merged 2 commits into from
Sep 23, 2019

Conversation

stephenlautier
Copy link
Contributor

Improvements

  • Implement max attempts for ClientGrain when not connected and force disconnect when exceeds as described in Connection fail to disconnect keeps client grain alive #96
  • OnDisconnect
    • Add finally to always remove from _connections store
    • Remove redundant manual remove for User group, as it is already handled via stream internally (was trying to remove twice)
  • OnConnect change order to first connect and then add to User group

@claylaut
Copy link
Collaborator

@galvesribeiro Can you please check it out when you have some free time ? thanks

galvesribeiro
galvesribeiro approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@galvesribeiro galvesribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galvesribeiro galvesribeiro merged commit 655fbfe into OrleansContrib:master Sep 23, 2019
@galvesribeiro
Copy link
Member

Sorry folks, will make a release soon. Thanks

@galvesribeiro
Copy link
Member

Published! https://www.nuget.org/packages/SignalR.Orleans/1.4.3

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvesribeiro galvesribeiro galvesribeiro approved these changes

@claylaut claylaut claylaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenlautier @claylaut @galvesribeiro