Set MEV fee recipient to FeeAccumulator for Native Staking Strategies

[naddison36]

Contract Changes

• Added setFeeRecipient to NativeStakingSSVStrategy that calls setFeeRecipientAddress on the SSVNetwork contract.
• Added SSV approve and setFeeRecipientAddress to the Native Staking Strategy's initialize function.

Updated Processes

Update the execution rewards to show transaction priority fee go to the strategy and only the MEV rewards go to the FeeAccumulator.

Updated the initialize function and required governance calls

Testing

Added Anyone should be able to set the MEV fee recipient test to the SSV Native Staking behaviour tests in contracts/test/behaviour/ssvStrategy.js.

Deployment

Holesky

# uncomment DEPLOYER_PK and GOVERNOR_PK in the .env file for the Holesky deployer PK

yarn run deploy:holesky

echo "module.exports = [{
  platformAddress: \"0x0000000000000000000000000000000000000000\",
  vaultAddress: \"0x19d2bAaBA949eFfa163bFB9efB53ed8701aA5dD9\",
},
\"0x94373a4919B3240D86eA41593D5eBa789FEF3848\", // WETH
\"0xad45A78180961079BFaeEe349704F411dfF947C6\", // SSV
\"0x38A4794cCEd47d3baf7370CcC43B560D3a1beEFA\", // SSVNetwork
500,
\"0x65a289f4BF934c964C942eFF6E6F83b6481BE550\", // feeAccumulator
\"0x4242424242424242424242424242424242424242\", // depositContract
]" > native-staking-args.js

npx hardhat --network holesky verify --contract contracts/strategies/NativeStaking/NativeStakingSSVStrategy.sol:NativeStakingSSVStrategy --constructor-args native-staking-args.js 0x94f150C1aA2aC65b59628a261C1Dd592785b7218

Mainnet

Added new deploy script to upgrade both the Native Staking Strategies and call setFeeRecipient.
contracts/deploy/mainnet/104_upgrade_staking_strategies.js

yarn run deploy:mainnet | tee $DEP_NUM.out

Code Change Checklist

To be completed before internal review begins:

• The contract code is complete
• Executable deployment file
• Fork tests that test after the deployment file runs
• Unit tests *if needed
• The owner has done a full checklist review of the code + tests

Internal review:

• Two approvals by internal reviewers

[github-actions]

	Warnings
⚠️	👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 8cec3de

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.07%. Comparing base (4effb95) to head (8cec3de).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2179      +/-   ##
==========================================
- Coverage   59.22%   59.07%   -0.16%     
==========================================
  Files          71       71              
  Lines        3505     3509       +4     
  Branches      910      687     -223     
==========================================
- Hits         2076     2073       -3     
- Misses       1426     1433       +7     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openzeppelin-code]

Set MEV fee recipient to FeeAccumulator for Native Staking Strategies

Generated at commit: 8cec3de61e163b72ff09a60017573f907803280f

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 3 0 18 42 66
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[shahthepro]

Should setFeeRecipient be made public and used here to avoid duplicate code?

[naddison36]

I thought about adding an internal _setFeeRecipient function that was called by initialize and setFeeRecipient but that seems overkill for one line. You're suggestion of a public setFeeRecipient is a better approach to the internal function. But I still think it's overkill for a single line. I think it makes it clearer what initialize does.

[sparrowDom]

nit: not a big deal, but this could also be called from the constructor

[naddison36]

it can't as it needs to come from the proxy contract, not the implementation contract. Hence it's in the initialize function.

[sparrowDom]

great job LGTM