Add UUID to 'temp' folder Fixes #28 #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The temporary folder gets deleted when orpheus_core_download finishes running. However, the temporary folder will be used by any other instance of orpheusdl that is running and the deletion of this folder will interfere with other instances. In order to prevent interference with other running instances of orpheusdl, here is a proposed change to create the temporary folder with a unique id that will not overlap.
removed unnecessary concatenations of the temp string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporary folder gets deleted when orpheus_core_download finishes running. However, the temporary folder will be used by any other instance of orpheusdl that is also running. The deletion of this folder will interfere with other instances.
In order to prevent interference with other running instances of orpheusdl, here is a proposed change to create the temporary folder with a folder id unique to that instance.