Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of the names for the "container class(es)" attribute #344

Closed
wwwysocki opened this issue Jan 18, 2017 · 2 comments
Closed

Comments

@wwwysocki
Copy link
Contributor

  1. Check the names for the "pal"-prefixed attributes in component XML files (pal:container-anti-class="" pal:container-class=""). Note the singular in use
  2. Check the name for the attribute to be used on a template's placeholder (ContainerClasses="") and and a label on page type's placeholder content element ("Container Classes"). Note the plural in use.
  3. Check the name and label for the parameter of the Composite.Widgets.String.VisualXhtmlEditor widget function (ContainerClasses). Note the plural in use.

Expected: Either the singular or the plural should be used everywhere.
Actual: Both the singular and the plural are used in different places

@kasravi
Copy link
Contributor

kasravi commented Jan 19, 2017

Correct, and using plural form is closer to the intended use

kasravi added a commit that referenced this issue Jan 19, 2017
@kasravi kasravi closed this as completed Jan 19, 2017
@wwwysocki
Copy link
Contributor Author

Verified in 20170124.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants