Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape double quotes and backslashes #5

Closed
agriffard opened this issue Aug 21, 2018 · 1 comment
Closed

Escape double quotes and backslashes #5

agriffard opened this issue Aug 21, 2018 · 1 comment

Comments

@agriffard
Copy link

You need to escape the double quotes in the msgid or the file is not valid.

Currently, you generate this:

#: OrchardCore.Flows\Views\Widget-Bag.Edit.cshtml:13
#. @T["{0} — <span class=\"hint\">{1}</span>", (await ContentManager.PopulateAspectAsync<ContentItemMetadata>(contentItem)).DisplayText, contentType]
msgctxt "OrchardCore.Flows.Views.Widget-Bag.Edit"
msgid "{0} — <span class="hint">{1}</span>"
msgstr ""

but the msgid should be:
msgid "{0} — <span class="\hint\">{1}</span>"

@agriffard agriffard changed the title Escape double quotes Escape double quotes and backslashes Aug 21, 2018
@agriffard
Copy link
Author

Also, please escape backslash \ with double backslashes \

lukaskabrt added a commit that referenced this issue Oct 13, 2018
lukaskabrt added a commit that referenced this issue Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants