EditTemplate buttons stick to top while scrolling #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good start, and a nice idea, but it needs more thinking. You can't have buttons that are sometimes in one place, and sometimes in another place. Please can it either be reverted or reworked My suggestion is the idea of sticky buttons is good. Move them to the right and top permanently. Make them sticky there. Don't show them in one place and then another. Don't have them overhang the text. Example from devops that works quite well.
/cc @hishamco @agriffard |
|
Reverted. @hishamco Can you please make a PR with the buttons at the top? |
|
@deanmarcussen I was thinking to move them to the right, but seems @agriffard merged quickly, I will start a new PR |
|
The PR #8067 is created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087