Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jint and add unit test #7485

Merged
merged 5 commits into from
Nov 7, 2020
Merged

Update Jint and add unit test #7485

merged 5 commits into from
Nov 7, 2020

Conversation

jptissot
Copy link
Member

@jptissot jptissot commented Nov 2, 2020

Found an issue with the latest Jint. This adds some simple unit tests that show the issue.

Fix #7452

@jptissot jptissot changed the title Update Jint and add failing unit test Update Jint and add unit test Nov 2, 2020
@jptissot
Copy link
Member Author

jptissot commented Nov 6, 2020

@sebastienros Looks like this issue is fixed. Do you want to keep these unit tests here or should I remove them because they are now in Jint ?

@jptissot jptissot requested a review from sebastienros November 6, 2020 19:32
@sebastienros
Copy link
Member

Remove them, thanks

@jptissot jptissot added the ready label Nov 6, 2020
@jptissot jptissot merged commit 8c5ce19 into dev Nov 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the jptissot/jint branch November 7, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception with latest JInt
2 participants