Asset Manager fixes #17531
Merged
Asset Manager fixes #17531
+35
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean Parcel destination folder for each assets before running action. Parcel doesn't allow overwriting files so we need to keep them in separate folders to clean them before build or watch. Fix min action issue that deletes the unminified file after minifying.
|
Merging this as these are fixes for Parcel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where running
yarn watch -n parcel-assetwas not updating the asset in the destination folder. Also was failing silently doing so. Workaround was to delete manually these files in the destination folder.Clean Parcel destination folder for each assets before running action. Parcel doesn't allow overwriting files so we need to keep them in separate folders to clean them before build or watch.
Fix min action issue that deletes the unminified file after minifying.