-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources dependencies fixes and Vue 3 #17528
base: main
Are you sure you want to change the base?
Conversation
Move old dependencies to Vendor folder and make sure that they get copied to wwwroot for reproducible builds. Add Vue 3 and make it current dependency. Removing Bootstrap 3 dependency as it was not even copied to the wwwroot folder anymore. Rename vuedraggable to vue-draggable resource.
Fixes issue with build and watch not updating files
I'm sure it's awesome but I don't think I have the review of another multi-hundred file resource management PR in me so soon :). What does it fix (as oppose to improve), specifically, i.e. what was broken? The Bootstrap 3 reference, anything else? |
Adds Vue 3 to the Resources and makes it possible to start using it. Other fixes are maintenance. |
Isn't that part of #14256? |
Yes, but without migrating anything. At least we can start creating Vue 3 components/apps. I'm splitting this other Vue 3 PR because of that. The Vue 3 PR should only contain migrated apps and tweaks if any. And also splitting because too many files makes the PR review impossible. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
# Conflicts: # src/OrchardCore.Themes/TheAdmin/Assets.json # src/OrchardCore.Themes/TheAdmin/ResourceManagementOptionsConfiguration.cs
Move old dependencies to Vendor folder and make sure that they get copied to wwwroot for reproducible builds.
Add Vue 3 and make it current dependency.
Removing Bootstrap 3 dependency as it was not even copied to the wwwroot folder anymore.
Rename vuedraggable to vue-draggable resource.
Migrate OrchardCore.Liquid GulpAssets.json to Assets.json using a run command.
Add Vue 3 vue-draggable and vue-multiselect new versions.
This is the core changes required to start migrating to Vue 3 our components or to simply allow people to start creating new Vue 3 apps/components.
Also @sebastienros
We can run
tsc
directly with the new Asset Manager tool with the "run" action. See example used in this PR:This is why there was no need to recreate a "typescript" only action. You can run the command shell line right there with all required params.
Here is the GulpAssets.json equivalent config:
As we can see it was not that easy to understand either based on the fact that you still need to know which configurations
tsc
has. Also, everything needed to be passed as a JSON object which we have literally no documentation about.