New Asset Build Tool #17262
Open
New Asset Build Tool #17262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/OrchardCore.Modules/OrchardCore.AdminDashboard/Assets.json # src/OrchardCore.Modules/OrchardCore.AdminMenu/Assets.json # src/OrchardCore.Modules/OrchardCore.AdminMenu/wwwroot/Scripts/admin-menu-icon-picker.js # src/OrchardCore.Modules/OrchardCore.Media/ResourceManifestOptionsConfiguration.cs # src/OrchardCore.Modules/OrchardCore.Resources/package.json
Piedone
requested changes
Dec 21, 2024
| "action": "sass", | ||
| "name": "admin-dashboard", | ||
| "source": "Assets/scss/dashboard.scss", | ||
| "dest": "wwwroot/Styles/", |
There was a problem hiding this comment.
Can this be (and Scripts) the default?
There was a problem hiding this comment.
We could surely do that.
src/OrchardCore.Modules/OrchardCore.AdminMenu/Views/Menu/List.cshtml
Outdated
Show resolved
Hide resolved
| "cleanup": "node .scripts/cleanup.js", | ||
| "build": "asset-bundler build", | ||
| "copy": "asset-bundler copy", | ||
| "watch": "asset-bundler watch", |
There was a problem hiding this comment.
The issue is that I'm not providing any Asset2.json bundler configuration yet.
- I will need to add an example.
- Will need to add a null check there so that it doesn't show this error message.
src/OrchardCore.Modules/OrchardCore.AdminMenu/package-lock.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
How did these change if the module is not yet updated?
There was a problem hiding this comment.
Yeah, I think it is because it is using Yarn latest version and it is resolving different version of dependencies/packages.
Co-authored-by: Zoltán Lehóczky <[email protected]>
…MS/OrchardCore into skrypt/asset-build-tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some extra work for me on Christmas holidays.🎅🏼
Assets Build Tool
Created by @jptissot
Based on Concurrently and Parcel but can also run Vite and probably Webpack too (untested). This is a non-opiniated build tool which allows to be extended for any asset compiler/bundler that someone may require.
This build tool essentially uses
Concurrentlyinstead ofGulp.Concurrently, is a concurrent shell runner which allows to trigger any possible shell command. It allows to triggerParcel,Vite,Gulpor any other command that we need for building assets. Everything is written as ES6 modules (.mjs files).Kind of needed for Vue 3 migration because it needs to use either
ViteorParcelto build as ES6 modules.Old assets are not compiled as ES6 modules so they don't need these bundlers. For that matter I kept the old gulpfile.js which will be now triggered by
Concurrently.What needs to be done over time is to migrate these javascript files to ES6 modules (.mjs files or .ts files) so that we can compile them as modules. But that's a migration that will happen over time.
Features
yarn buildyarn build -n module-nameyarn watch -n module-nameyarn build -gyarn build -grUpdate
Finally, I'm keeping the old gulp pipeline because there is nothing wrong with it. Also, for backward compatibility with older modules that requires it. I'm using
Assets2.jsonfor the new build tool simply. This way, no need to migrate to the new build tool. I'm simply triggeringgulp rebuildwithConcurrentlyin the new asset build tool. Because that's what it is essentially, a concurrent shell runner. This way, it is going to be a softer migration for those who already have modules that are built with the old gulp pipeline.Of course, this PR needs to be accepted by community first.
TODO
@jptissot @deanmarcussen @aderderian