Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssignRoleToUsers should not be implied by EditUsers #16954

Merged
merged 6 commits into from
Nov 25, 2024
Merged

AssignRoleToUsers should not be implied by EditUsers #16954

merged 6 commits into from
Nov 25, 2024

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Nov 5, 2024

Fixes #16756

@MikeAlhayek MikeAlhayek added this to the 3.0 milestone Nov 5, 2024
@MikeAlhayek
Copy link
Member

@hishamco the issue is tagged with 3.0. It is probably better to work on these issues when we are getting ready to release 3.0 to avoid conflicts and extra work

@hishamco
Copy link
Member Author

hishamco commented Nov 5, 2024

To be honest I'm not sure what is the roadmap, I think we should make this clear to everyone on the team

@MikeAlhayek
Copy link
Member

The issue is assigned to 3.0 milestones. That means it won't be merged in 2.x.

@hishamco hishamco modified the milestones: 3.0, 2.1 Nov 6, 2024
@hishamco
Copy link
Member Author

hishamco commented Nov 6, 2024

I changed it to 2.1.0

@MikeAlhayek
Copy link
Member

You can't change it. It's a breaking change. That's why it was tagged with 3.0.

@hishamco hishamco modified the milestones: 2.1, 3.0 Nov 6, 2024
@hishamco
Copy link
Member Author

hishamco commented Nov 6, 2024

While it's a bug we need to fix, this is a behavior breaking-change, I remembered we avoid code breaking-changes

@MikeAlhayek
Copy link
Member

its not a bug and has been like this for a long time. But we should not need that EditUsers permissions there.

@MikeAlhayek
Copy link
Member

@hishamco please document this change into 3.0.0 release notes and we'll merge it.

@hishamco hishamco requested a review from MikeAlhayek November 23, 2024 22:46
MikeAlhayek
MikeAlhayek requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@MikeAlhayek MikeAlhayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use descriptive docs in the release notes to help users understand what happened and what they should do to maintain behavior.

src/docs/releases/3.0.0.md Outdated Show resolved Hide resolved
@MikeAlhayek MikeAlhayek enabled auto-merge (squash) November 25, 2024 06:04
@MikeAlhayek MikeAlhayek merged commit 1cd5c1c into main Nov 25, 2024
8 checks passed
@MikeAlhayek MikeAlhayek deleted the hishamco/AssignRoleToUsers branch November 25, 2024 06:10
@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeAlhayek MikeAlhayek MikeAlhayek requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

AssignRoleToUsers should not be implied by EditUsers
2 participants
@hishamco @MikeAlhayek