Fix user menu text alignment

[mvarblow]

Fixes #16595

[hyzx86]

Can you provide screenshots before and after the fix? Thanks!

[hishamco]

As @hyzx86 said please share before and after screenshoot

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[mvarblow]

Hi @hishamco, @hyzx86. Thanks for taking a look. I included screen shots on the associated issue. #16595

[mvarblow]

It had merge conflicts with my other pull request from today. Those conflicts are resolved now. :)

[mvarblow]

The screenshots are included on #16595. But there's a bit more information I can provide...

The documentation on the (sometimes) missing fa-fw style is here:

https://docs.fontawesome.com/v5/web/style/fixed-width

Here are examples in Orchard Core user menu items where it was correctly included:

• https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenuItems-Title.cshtml
• https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenuItems-TwoFactor.cshtml
• https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenuItems-Dashboard.cshtml
• https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenuItems-ChangeEmail.cshtml
• https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenuItems-ExternalLogins.cshtml
• https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenuItems-Title.DetailAdmin.cshtml

Of course there are the two files (see "Files changed" tab) where it was missing.

[Piedone]

@gvkries when you approve a PR, and especially for someone who doesn't have merge permissions, please also merge right away after waiting for the functional tests to pass. Or, if you're waiting for a second opinion, make it explicit with a comment (and then merge after like 1-2 days if nobody else chimes in, so we don't have PRs lingering indefinitely).