Refactorings in preparation of .NET 9.0 support #16575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
gvkries
approved these changes
Aug 16, 2024
[ci-skip] Co-authored-by: Georg von Kries <[email protected]>
Piedone
approved these changes
Aug 16, 2024
hishamco
reviewed
Aug 16, 2024
| @@ -356,6 +358,19 @@ public static string TrimEnd(this string value, string trim = "") | |||
| ? value[..^trim.Length] | |||
| : value; | |||
| } | |||
| #endif | |||
|
|
|||
| public static string TrimEndString(this string value, string suffix) | |||
There was a problem hiding this comment.
Could you please elaborate what are the different behaviors?
In both cases, we can have the same name and move #if .. #elseif .. #endif inside the function, this way no need to have a new method name
There was a problem hiding this comment.
TrimEnd exists in net9.0, so we need to hide it when we build in net9.0.
And in net9.0 TrimEnd("Part") is equivalent to TrimEnd(new char[] { 'P', 'a', 'r', 't' }) so "MenuListPart" would become "MenuLis" without the t.
There was a problem hiding this comment.
Seems a new overload has been added in .NET 9.0
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes that would have to be made when supporting .NET 9 and can/should come in 2.0 release instead
This way the .NET 9 branch is only about .NET 9 changes