Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small optimizations for the ExtensionManager #16382

Merged
merged 25 commits into from
Jul 24, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f5892d6
Fixes that type/feature mappings are not available during setup.
gvkries Jun 14, 2024
d486a0d
Merge branch 'main' into gvkries/setup-dependencies-16289
gvkries Jun 18, 2024
05ba3a8
Merge branch 'main' into gvkries/setup-dependencies-16289
gvkries Jun 20, 2024
8b3f093
Merge branch 'main' into gvkries/setup-dependencies-16289
gvkries Jun 26, 2024
8a1a244
Merge branch 'main' into gvkries/setup-dependencies-16289
gvkries Jun 27, 2024
b794726
Makes sure all types are added to the ITypeFeatureProvider, even if t…
gvkries Jun 27, 2024
2376f97
Merge branch 'main' into gvkries/shellblueprint-16375
gvkries Jun 28, 2024
f72538a
Performance optimizations and simplifications of extension manager.
gvkries Jun 28, 2024
e0b6064
Types only required during startup could be registered as transient i…
gvkries Jun 28, 2024
d728199
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 1, 2024
b25c2a2
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 3, 2024
56a1137
Use file scoped namespace and added some basic trace messages.
gvkries Jul 3, 2024
1e3a472
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 4, 2024
1c4c28e
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 8, 2024
442be6a
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 15, 2024
7c43f31
Revert file scoped namespace usage.
gvkries Jul 15, 2024
98ba964
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 16, 2024
acc84d9
Move extension manager initialization back into a separate method.
gvkries Jul 16, 2024
b1fce16
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 17, 2024
0e77cde
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 22, 2024
475c787
Update src/OrchardCore/OrchardCore/Extensions/ExtensionManager.cs
gvkries Jul 22, 2024
a178a9d
React to code review.
gvkries Jul 22, 2024
7b06d69
Merge branch 'main' into gvkries/exmgr-optimzations
MikeAlhayek Jul 22, 2024
d107ccc
Update src/OrchardCore/OrchardCore/Extensions/ExtensionManager.cs
gvkries Jul 23, 2024
47a54e8
Merge branch 'main' into gvkries/exmgr-optimzations
gvkries Jul 23, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Types only required during startup could be registered as transient i…
…n DI.
gvkries committed Jun 28, 2024
commit e0b6064fcbe7efd7fb8fd235c7d22cf969ab5324
Original file line number Diff line number Diff line change
@@ -124,8 +124,8 @@ public static OrchardCoreBuilder AddThemingHost(this OrchardCoreBuilder builder)
{
var services = builder.ApplicationServices;

services.AddSingleton<IExtensionDependencyStrategy, ThemeExtensionDependencyStrategy>();
services.AddSingleton<IFeatureBuilderEvents, ThemeFeatureBuilderEvents>();
services.AddTransient<IExtensionDependencyStrategy, ThemeExtensionDependencyStrategy>();
services.AddTransient<IFeatureBuilderEvents, ThemeFeatureBuilderEvents>();

return builder;
}
Original file line number Diff line number Diff line change
@@ -10,9 +10,9 @@ public static IServiceCollection AddExtensionManagerHost(this IServiceCollection
{
services.AddSingleton<IExtensionManager, ExtensionManager>();
services.AddSingleton<ITypeFeatureProvider, TypeFeatureProvider>();
services.AddSingleton<IFeaturesProvider, FeaturesProvider>();
services.AddSingleton<IExtensionDependencyStrategy, ExtensionDependencyStrategy>();
services.AddSingleton<IExtensionPriorityStrategy, ExtensionPriorityStrategy>();
services.AddTransient<IFeaturesProvider, FeaturesProvider>();
services.AddTransient<IExtensionDependencyStrategy, ExtensionDependencyStrategy>();
services.AddTransient<IExtensionPriorityStrategy, ExtensionPriorityStrategy>();

return services;
}