Fix Content-Types and Content-Parts search UI

[MikeAlhayek]

Before this, if you click enter in the text box you'll get a 404. Also, the keyCode property on the JavaScript is deprecated.

Also, now we no longer need jQuery for this to work. And the logic is reusable.

Here is a quick demo of the UI behavior for both content-types and content-parts UI.

[Piedone]

I see the Enter issue, but not the Esc one. On main, if I hit Esc when searching, then the search box will be cleared and the filtering removed:

2024-06-05_01h35_45.mp4

This is exactly what I'd expect to happen. What behavior is this fixing for Esc?

[MikeAlhayek]

I don't think there was an issue with escape actually. There is a deprecated warning. But the enter is definitely a problem. I updated the description.

Let me know if you see an issue with the current PR.

[Piedone]

I'll review it soon.

[Piedone]

I still get a 404 on Enter:

2024-06-05_23h20_16.mp4

[MikeAlhayek]

I still get a 404 on Enter:

I am guessing you need to do a deep refresh CTRL + F5. It works with no issues for me (just tried it out again). Look at the video in the description to see how it works for me.

[Piedone]

I did that. With the DevTools open the cache is disabled anyway.

[MikeAlhayek]

Can you please check the generated HTML? ensure that the old script is removed and the list-items-filter.js is included

[Piedone]

Now it works, WTF. Anyway, I'll continue with the code review.