-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoginInfoConverter #15422
Add LoginInfoConverter #15422
Conversation
@hyzx86 I made some changes to the PR. Can you please confirm that the code change work in your environment? |
public class DeploymentPlan
{
public long Id { get; set; }
public string Name { get; set; }
public List<DeploymentStep> DeploymentSteps { get; init; } = [];
}
public abstract class DeploymentStep
{
public string Id { get; set; }
public string Name { get; set; }
} |
src/OrchardCore/OrchardCore.Abstractions/Extensions/JsonSerializerOptionsConfiguration.cs
Outdated
Show resolved
Hide resolved
@hyzx86 are you using custom deployment steps? Make sure you follow all the breaking changes steps here (use services.AddDeployment<>) extension to register it. |
Yes, my suggestion is to implement a fake serialization converter, and if there are incorrect registrations in the user's data, output a log here, guiding the user to add them using the correct registration method |
We logged the instruction in the release notes to ensure that users are able to follow during migration. |
@hyzx86 look at the simple test I added. It works as expected. You can add additional tests if you like by creating User object and evaluating the UserLoginInfo collection. Any additional issues you have, maybe due to something else. |
@MikeAlhayek I also added a test, which I felt was more realistic Unfortunately, it doesn't seem to work |
Ok, so far everything looks good |
@hyzx86 thank you! I cleaned up the tests. Merging it. |
--------- Co-authored-by: Mike Alhayek <[email protected]> Co-authored-by: hyzx86 <[email protected]>
try fix #15416