Update the ContentElement constructor #15365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns8482e
reviewed
Feb 19, 2024
| @@ -14,11 +14,11 @@ public class ContentElement : IContent | |||
| private Dictionary<string, ContentElement> _elements; | |||
| private JsonDynamicObject _dynamicObject; | |||
|
|
|||
| internal ContentElement() : this([]) | |||
| protected ContentElement() : this([]) | |||
There was a problem hiding this comment.
Because it was protected before merging the references PR. Protected will allow us to continue to be able to inherit from it and does not break anyone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14572 changed the constructor type from protected to internal. I do not see the reason for this change but it cause breaking change for anyone that inherits from it.