regenerate activity URL when importing Workflows

[lampersky]

fixes #15087

[hishamco]

Why the build fail in Ubuntu?

[lampersky]

Why the build fail in Ubuntu?

no idea @hishamco , can you rerun the build?

[hishamco]

Sure I will re-run this again

[sebastienros]

Already did, failed again.

[sebastienros]

CORS issue (check the messages). Maybe some node version problem in the scripts, there are warnings in the build.

[hishamco]

The issue related to the JSON conversion, @lampersky please check the logs

https://github.com/OrchardCMS/OrchardCore/actions/runs/7843466469/job/21417779248?pr=15291

[sebastienros]

I had not thought about this, these functional test recipes are only run on Linux, and the coming soon one imports a workflow for the subscription form. So it makes sense now. Here is the error message:

      System.Text.Json.JsonException: The JSON value could not be converted to System.Int32. Path: $ | LineNumber: 0 | BytePositionInLine: 4.
       ---> System.InvalidOperationException: Cannot get the value of a token type 'Null' as a number.
         at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_ExpectedNumber(JsonTokenType tokenType)
         at System.Text.Json.Utf8JsonReader.TryGetInt32(Int32& value)
         at System.Text.Json.Serialization.Converters.Int32Converter.Read(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options)
         at System.Text.Json.Serialization.JsonConverter`1.TryRead(Utf8JsonReader& reader, Type typeToConvert, JsonSerializerOptions options, ReadStack& state, T& value, Boolean& isPopulatedValue)
         at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
         --- End of inner exception stack trace ---
         at System.Text.Json.ThrowHelper.ReThrowWithPath(ReadStack& state, Utf8JsonReader& reader, Exception ex)
         at System.Text.Json.Serialization.JsonConverter`1.ReadCore(Utf8JsonReader& reader, JsonSerializerOptions options, ReadStack& state)
         at System.Text.Json.Serialization.Metadata.JsonTypeInfo`1.Deserialize(Utf8JsonReader& reader, ReadStack& state)
         at System.Text.Json.JsonSerializer.ReadFromSpan[TValue](ReadOnlySpan`1 utf8Json, JsonTypeInfo`1 jsonTypeInfo, Nullable`1 actualByteCount)
         at System.Text.Json.JsonSerializer.ReadFromNode[TValue](JsonNode node, JsonTypeInfo`1 jsonTypeInfo)
         at System.Text.Json.JsonSerializer.Deserialize[TValue](JsonNode node, JsonSerializerOptions options)
         at System.Text.Json.Nodes.JNode.ToObject[T](JsonNode jsonNode, JsonSerializerOptions options) in /_/src/OrchardCore/OrchardCore.Abstractions/Json/Nodes/JNode.cs:line 100
         at OrchardCore.Workflows.Recipes.WorkflowTypeStep.ReGenerateHttpRequestEventUrl(WorkflowType workflow, ActivityRecord activity) in /_/src/OrchardCore.Modules/OrchardCore.Workflows/Recipes/WorkflowTypeStep.cs:line 66
         at OrchardCore.Workflows.Recipes.WorkflowTypeStep.ExecuteAsync(RecipeExecutionContext context) in /_/src/OrchardCore.Modules/OrchardCore.Workflows/Recipes/WorkflowTypeStep.cs:line 46

[sebastienros]

Should it actually try to generate the token property if there is no or invalid tokenlifespan?

[sebastienros]

For instance if a request has no token, this code here would generate a 0-lifespan one so the request would fail, right?

[lampersky]

In my opinion, it's better to go with infinite token lifespan than no working activity at all. But it is up to you. What is your preference here?

[sebastienros]

than no working activity at all

I don't understand, maybe I am missing some info. I thought that you could have request workflow that are not protected by a token. Is that correct? In that case you would still generate a token even if it's not necessary with your first suggestion.

[lampersky]

I thought that you could have request workflow that are not protected by a token. Is that correct?

no, every request to any HttpRequestEvent is protected by a token, a token is just an ecrypted json (it contains workflowId and ActivityId), this token has some lifespan, even if it isn't provided we are using some predefined value (100 years = ~36500 days)

[sebastienros]

Thanks, I didn't remember the details.

[lampersky]

@sebastienros To maintain backward compatibility, I will treat activities without a provided timespan as never expiring.
Here it is part of comingsoon.recipe.json:

[sebastienros]

@lampersky good. However might still be better to not add a token if there were none before, assuming that's something that can happen. Shouldn't be hard in code either, just a condition before generating the link instead of defaulting to infinite lifetime.

[lampersky]

@sebastienros I've just pushed suggested changes. The activity URL is only refreshed when token life time is provided.
Now windows build is failing :-D