Add warnings for CORS policies #15258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owCredentials" are set to true.
MikeAlhayek
requested changes
Feb 13, 2024
src/OrchardCore.Modules/OrchardCore.Cors/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Cors/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Cors/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Cors/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
…roller.cs Co-authored-by: Mike Alhayek <[email protected]>
…roller.cs Co-authored-by: Mike Alhayek <[email protected]>
…roller.cs Co-authored-by: Mike Alhayek <[email protected]>
MikeAlhayek
reviewed
Feb 13, 2024
src/OrchardCore.Modules/OrchardCore.Cors/Controllers/AdminController.cs
Outdated
Show resolved
Hide resolved
MikeAlhayek
approved these changes
Feb 13, 2024
MikeAlhayek
reviewed
Feb 13, 2024
|
@MikeAlhayek can this please be merged. |
urbanit
pushed a commit
to urbanit/OrchardCore
that referenced
this pull request
Mar 18, 2024
Co-authored-by: Mike Alhayek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when both "AllowAnyOrigin" and "AllowCredentials" are set to true.
Cors wont work if both "AllowAnyOrigin" and "AllowCredentials" are set to true.
Alert user for these cases and refer to documentation.