Add ISmtpService extension methods

[hishamco]

No description provided.

[hishamco]

@MikeAlhayek please review if you have time, just simple extension methods to simplify sending the emails

[MikeAlhayek]

@hishamco
Can we please finish the other Email PR first and revisit this after?

[hishamco]

Seems the Azure Email will takes so long after the tons of feedback :)

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[Piedone]

This will need to wait for #14715.

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[hishamco]

I need to merge this if no one has any comment because I need to continue on PR #14715

[Piedone]

I'm otherwise OK with this, @MikeAlhayek?

If we'll also merge #14715 then this extension's signature will need to be changed too, but OK.

[MikeAlhayek]

I am good with that one extension.

[hishamco]

@MikeAlhayek the last refactoring looks much better

[Piedone]

I don't think the last commit brings any value but makes the code more complex. I'm OK with the code before that.

[hishamco]

I don't think the last commit brings any value but makes the code more complex. I'm OK with the code before that.

I don't think so :) I'm not sure why we need two methods that do the exact thing except one for the subject and the other for the body

[Piedone]

The difference boils down to the fact that instead of having a GetSubjectAsync and GetBodyAsync separately, there's a tuple-returning GetSubjectAndBodyAsync that does it for both. This isn't better: The code does the same operations as before (i.e. no reduction) but instead of having a structured approeach of three specific methods, does all in one mixed together. The tuple is a code smell of this too.

[hishamco]

I will revert back to the last commit and then merge