Create a separate data migration

src/OrchardCore.Modules/OrchardCore.Roles/Migrations/RolesMigrations.cs

@@ -16,19 +16,13 @@ public sealed class RolesMigrations : DataMigration
     private static readonly string _alternativeAdminRoleName = "SiteOwner";
 
     private readonly SystemRoleOptions _systemRoleOptions;
-    private readonly ISystemRoleNameProvider _systemRoleNameProvider;
-    private readonly RoleManager<IRole> _roleManager;
     private readonly ILogger _logger;
 
     public RolesMigrations(
         IOptions<SystemRoleOptions> systemRoleOptions,
-        ISystemRoleNameProvider systemRoleNameProvider,
-        RoleManager<IRole> roleManager,
         ILogger<RolesMigrations> logger)
     {
         _systemRoleOptions = systemRoleOptions.Value;
-        _systemRoleNameProvider = systemRoleNameProvider;
-        _roleManager = roleManager;
         _logger = logger;
     }
 
@@ -132,18 +126,6 @@ await HttpBackgroundJob.ExecuteAfterEndOfRequestAsync("MigrateAdminUsersToNewAdm
         return 1;
     }
 
-    public async Task<int> UpdateFrom1Async()
-    {
-        var systemRoles = await _systemRoleNameProvider.GetSystemRolesAsync();
-
-        foreach (var role in systemRoles)
-        {
-            await _roleManager.CreateAsync(new Role { RoleName = role });
-        }
-
-        return 2;
-    }
-
     private static string GenerateNewAdminRoleName(List<IRole> roles)
     {
         var counter = 1;

src/OrchardCore.Modules/OrchardCore.Roles/Migrations/SystemRolesMigrations.cs

@@ -0,0 +1,37 @@
+using Microsoft.AspNetCore.Identity;
+using Microsoft.Extensions.Logging;
+using OrchardCore.Data.Migration;
+using OrchardCore.Security;
+
+namespace OrchardCore.Roles.Migrations;
+
+public sealed class SystemRolesMigrations : DataMigration
+{
+    private readonly ISystemRoleNameProvider _systemRoleNameProvider;
+    private readonly RoleManager<IRole> _roleManager;
+    private readonly ILogger _logger;
+
+    public SystemRolesMigrations(
+        ISystemRoleNameProvider systemRoleNameProvider,
+        RoleManager<IRole> roleManager,
+        ILogger<RolesMigrations> logger)
+    {
+        _systemRoleNameProvider = systemRoleNameProvider;
+        _roleManager = roleManager;
+        _logger = logger;
+    }
+
+    public async Task<int> CreateAsync()
+    {
+        var systemRoles = await _systemRoleNameProvider.GetSystemRolesAsync();
+
+        foreach (var role in systemRoles)
+        {
+            await _roleManager.CreateAsync(new Role { RoleName = role });
+        }
+
+        _logger.LogInformation("The system roles have been created successfully.");
+
+        return 1;
+    }
+}

src/OrchardCore.Modules/OrchardCore.Roles/Startup.cs

@@ -33,7 +33,10 @@ public Startup(IShellConfiguration shellConfiguration)
     public override void ConfigureServices(IServiceCollection services)
     {
         services.AddScoped<IUserClaimsProvider, RoleClaimsProvider>();
-        services.AddDataMigration<RolesMigrations>();
+
+        services.AddDataMigration<SystemRolesMigrations>()
+            .AddDataMigration<RolesMigrations>();
+
         services.AddScoped<RoleStore>();
         services.Replace(ServiceDescriptor.Scoped<IRoleClaimStore<IRole>>(sp => sp.GetRequiredService<RoleStore>()));
         services.Replace(ServiceDescriptor.Scoped<IRoleStore<IRole>>(sp => sp.GetRequiredService<RoleStore>()));