Fix menu item deletion (#15500)

OrchardCMS · Mar 21, 2024 · 28bd184 · 28bd184
1 parent 839bccb
commit 28bd184
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs b/src/OrchardCore.Modules/OrchardCore.Menu/Controllers/AdminController.cs
@@ -270,16 +270,18 @@ public async Task<IActionResult> Delete(string menuContentItemId, string menuIte
                 return NotFound();
             }
 
+            var menuContentAsJson = (JsonObject)menu.Content;
             // Look for the target menu item in the hierarchy.
-            var menuItem = FindMenuItem((JsonObject)menu.Content, menuItemId);
+            var menuItem = FindMenuItem(menuContentAsJson, menuItemId);
 
             // Couldn't find targeted menu item.
             if (menuItem == null)
             {
                 return NotFound();
             }
 
-            menu.Content.Remove(menuItemId);
+            var menuItems = menuContentAsJson[nameof(MenuItemsListPart)]?[nameof(MenuItemsListPart.MenuItems)] as JsonArray;
+            menuItems?.Remove(menuItem);
 
             await _contentManager.SaveDraftAsync(menu);