-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add google tag manager #807
Docs: Add google tag manager #807
Conversation
✅ Deploy Preview for ods-android canceled.
|
@louismaximepiton Thank you for this submission, it works. I think it's a good proposition to add it in the |
…google-tag-manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job @louismaximepiton
Let's try to tackle my comment to help future contributors build a local env.
After the merge of this PR, we'll need to double-check that:
- analytics are available in the tool
- when pages are embedded to Zeroheight, the cookies banner is not displayed (and no cookies are stored obviously)
I'll then create an issue in https://github.com/Orange-OpenSource/ods-jekyll-theme to try to embed these modifications directly into the theme.
8335200
to
6a55956
Compare
Description
.gitmodules
url in order to not force people to forkods-jekyll-theme
as well.What needs to be reviewed at least
main.html
aren't breakingMisc
Need to be careful once the
ods-jekyll-theme
is updated with boosted v5.3.x, both the script and the associated css need to be changed.Should we try to set it on
ods-jekyll-theme
lib to ease the maintenance on all lib using the theme ?