Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add google tag manager #807

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 6, 2024

Description

  • Changed the .gitmodules url in order to not force people to fork ods-jekyll-theme as well.
  • Added the cookies management using TarteAuCitron
  • Added the custom scripts and custom CSS
  • Added a page in the doc to handle the cookies once the first interaction is made.
  • Generated the hash using https://www.srihash.org/

What needs to be reviewed at least

  • The Cookies panel is visible (make sure to not use Firefox)
  • Make sure the cookies are fine
  • The Panel can be accessed from somewhere inside the website
  • Define what to put inside the Cookies page
  • Make sure the changes in main.html aren't breaking

Misc

Need to be careful once the ods-jekyll-theme is updated with boosted v5.3.x, both the script and the associated css need to be changed.
Should we try to set it on ods-jekyll-theme lib to ease the maintenance on all lib using the theme ?

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for ods-android canceled.

Name Link
🔨 Latest commit 6a55956
🔍 Latest deploy log https://app.netlify.com/sites/ods-android/deploys/65ccd02b95f3ab000865859a

paulinea
paulinea previously approved these changes Feb 9, 2024
@paulinea
Copy link
Member

paulinea commented Feb 9, 2024

@louismaximepiton Thank you for this submission, it works. I think it's a good proposition to add it in the ods-jekyll-theme. It can be done in a second time.

paulinea
paulinea previously approved these changes Feb 9, 2024
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @louismaximepiton
Let's try to tackle my comment to help future contributors build a local env.
After the merge of this PR, we'll need to double-check that:

  • analytics are available in the tool
  • when pages are embedded to Zeroheight, the cookies banner is not displayed (and no cookies are stored obviously)

I'll then create an issue in https://github.com/Orange-OpenSource/ods-jekyll-theme to try to embed these modifications directly into the theme.

.gitmodules Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton force-pushed the develop-lmp-add-google-tag-manager branch from 8335200 to 6a55956 Compare February 14, 2024 14:37
@paulinea paulinea merged commit 13bda43 into Orange-OpenSource:develop Feb 14, 2024
8 checks passed
@louismaximepiton louismaximepiton deleted the develop-lmp-add-google-tag-manager branch February 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants