Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card Button alignement review #620

Closed
B3nz01d opened this issue Aug 23, 2023 · 0 comments · Fixed by #790
Closed

Card Button alignement review #620

B3nz01d opened this issue Aug 23, 2023 · 0 comments · Fixed by #790
Labels
⚛️ Component 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Aug 23, 2023 •
edited by paulinea
Loading

In this screenshot the device does not have enough space to show both buttons on a card.

If the text is too long to fit on one line, the second button should be put on a second line.
@B3nz01d B3nz01d added 🧩 enhancement New feature or request ⚛️ Component labels Aug 23, 2023
@paulinea paulinea assigned paulinea and unassigned mccart77 Jan 22, 2024
paulinea added a commit that referenced this issue Jan 23, 2024
@paulinea
[#620] Use FlowRow to display cards buttons and improve previews
15ebc74
paulinea added a commit that referenced this issue Jan 23, 2024
@paulinea
[#620] Update changelog
4a791b0
@paulinea paulinea linked a pull request Jan 23, 2024 that will close this issue
620 - Cards - Stack buttons when texts are too long to fit on one line #790
Merged
@ludovic35 ludovic35 mentioned this issue Jan 24, 2024
Closed
florentmaitre added a commit that referenced this issue Jan 24, 2024
@florentmaitre
[#620] Review: Fix bug where a single button was not displayed in Ods…
37f9129 
…HoritontalCard
@paulinea paulinea assigned paulinea and unassigned paulinea Jan 25, 2024
@B3nz01d B3nz01d assigned mccart77 and afrahB and unassigned B3nz01d Feb 7, 2024
@mccart77 mccart77 removed their assignment Mar 1, 2024
@afrahB afrahB removed their assignment Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚛️ Component 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
🟢 [ods-Android] Sprint 29 - Mar - Apr 2024
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

620 - Cards - Stack buttons when texts are too long to fit on one line Orange-OpenSource/ods-android
4 participants
@paulinea @B3nz01d @mccart77 @afrahB