Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chips - Update variants #494

Closed
paulinea opened this issue Mar 27, 2023 · 0 comments · Fixed by #499
Closed

Chips - Update variants #494

paulinea opened this issue Mar 27, 2023 · 0 comments · Fixed by #499
Labels
📱 demo app 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@paulinea
Copy link
Member

paulinea commented Mar 27, 2023 •
edited
Loading

Today we have the following chips:

  • Chip
  • Filter chip

The objective is to have the following:

  • Action chip (subtitle: OdsChip)
  • Choice chip (subtitle: OdsChip)
  • Input chip (subtitle: OdsChip)
  • Filter chip (subtitle: OdsFilterChip)

In the chip variant, remove type customization.
@paulinea paulinea added 🔍 triage A new issue that needs to be treated 📱 demo app labels Mar 27, 2023
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Mar 27, 2023
@paulinea paulinea changed the title Update chips variants Chips - Update variants Mar 27, 2023
@paulinea paulinea self-assigned this Mar 30, 2023
paulinea added a commit that referenced this issue Mar 31, 2023
@paulinea
[#494] Display type of chips as variants of chip component
3b35e97
paulinea added a commit that referenced this issue Mar 31, 2023
@paulinea
[#494] Update changelog
e574e2b
@paulinea paulinea linked a pull request Mar 31, 2023 that will close this issue
494 - Chips - Update variants #499
Merged
florentmaitre pushed a commit that referenced this issue Apr 4, 2023
@paulinea @florentmaitre
[#494] Display type of chips as variants of chip component
0feda6d
florentmaitre pushed a commit that referenced this issue Apr 4, 2023
@paulinea @florentmaitre
[#494] Update changelog
9c9d550
@paulinea paulinea assigned B3nz01d and mccart77 and unassigned paulinea Apr 6, 2023
@B3nz01d B3nz01d assigned afrahB and unassigned B3nz01d Jun 12, 2023
@afrahB afrahB removed their assignment Jul 5, 2023
@mccart77 mccart77 removed their assignment Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📱 demo app 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

494 - Chips - Update variants Orange-OpenSource/ods-android
4 participants
@paulinea @B3nz01d @mccart77 @afrahB