Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the icon buttons #484

Closed
B3nz01d opened this issue Mar 20, 2023 · 1 comment · Fixed by #496
Closed

Update the icon buttons #484

B3nz01d opened this issue Mar 20, 2023 · 1 comment · Fixed by #496
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Mar 20, 2023

Today we have the following buttons:

  • Highest emphasis buttons
  • High emphasis buttons
  • Medium emphasis buttons
  • Low buttons
  • Functional buttons
  • Toggle buttons
  • Icon buttons

The objective is to build the following:

  • Buttons (only keeps the following items):
    • Highest emphasis buttons
    • High emphasis buttons
    • Medium emphasis buttons
    • Low buttons
    • Functional buttons
  • Buttons: icons (New component with the following items)
    • Outline icon buttons
    • Standard Icon buttons
      • 2 states are possible with or without toggle (in the customization bottom sheet: Toggle using a switch for user selection)
    • Group Toggle button (the behavior is that you can select 0, 1, on more at a time)
@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated 📱 demo app ⚛️ Component labels Mar 20, 2023
@paulinea
Copy link
Member

@B3nz01d @ChristineKuster We need an illustration for the "Buttons: icons" component for Orange and generic theme (black & white)

@paulinea paulinea assigned ChristineKuster and unassigned paulinea Mar 24, 2023
@paulinea paulinea removed 🔍 triage A new issue that needs to be treated ⚙️ spec review labels Mar 27, 2023
@paulinea paulinea assigned paulinea and unassigned ChristineKuster Mar 27, 2023
paulinea added a commit that referenced this issue Mar 27, 2023
@paulinea
[#484] Split buttons and icons buttons in separated components
5a291dd
paulinea added a commit that referenced this issue Mar 28, 2023
@paulinea
[#484] Split buttons and icons buttons in separated components
155ab15
paulinea added a commit that referenced this issue Mar 29, 2023
@paulinea
[#484] Update buttons icon variants
b9eec73
paulinea added a commit that referenced this issue Mar 29, 2023
@paulinea
[#484] Use a callback instead of a mutable state for icon button togg…
a6f0abd 
…le group selection
paulinea added a commit that referenced this issue Mar 29, 2023
@paulinea
[#484] Update icon buttons documentation
f0e8e74
@paulinea paulinea linked a pull request Mar 29, 2023 that will close this issue
484 - Buttons: icons - Update icons buttons in a new component #496
Merged
paulinea added a commit that referenced this issue Mar 29, 2023
@paulinea
[#484] Fix documentation images
e77d281
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Resize image
d107de8
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Update changelog
643f415
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Split buttons and icons buttons in separated components
946be4f
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Update buttons icon variants
ed474c4
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Use a callback instead of a mutable state for icon button togg…
a951ee5 
…le group selection
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Update icon buttons documentation
db74473
paulinea added a commit that referenced this issue Mar 30, 2023
@paulinea
[#484] Fix documentation images
8750b2e
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned paulinea Apr 6, 2023
@B3nz01d B3nz01d removed their assignment Jun 12, 2023
@afrahB afrahB removed their assignment Jun 28, 2023
@mccart77 mccart77 assigned mccart77 and unassigned mccart77 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

484 - Buttons: icons - Update icons buttons in a new component Orange-OpenSource/ods-android
5 participants
@paulinea @B3nz01d @mccart77 @afrahB @ChristineKuster