Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Image height is wrong in some cases in OdsHorizontalCard #445

Closed
florentmaitre opened this issue Mar 1, 2023 · 0 comments · Fixed by #461
Closed

Bug - Image height is wrong in some cases in OdsHorizontalCard #445

florentmaitre opened this issue Mar 1, 2023 · 0 comments · Fixed by #461
Labels
🐞 bug Something isn't working ⚛️ Component 👌 OK Design 👌 OK PO

Comments

@florentmaitre
Copy link
Member

To reproduce, in CardHorizontal.kt replace:

image = rememberAsyncImagePainter(
    model = recipe.imageUrl,
    placeholder = painterResource(id = R.drawable.placeholder),
    error = painterResource(id = R.drawable.placeholder)
),

with:

image = rememberAsyncImagePainter(
    model = ImageRequest.Builder(context)
        .data(recipe.imageUrl)
        .size(Size(800, 800))
        .build(),
    placeholder = painterResource(id = R.drawable.placeholder),
    error = painterResource(id = R.drawable.placeholder)
),

Screenshot_20230301_180751
@florentmaitre florentmaitre added 🐞 bug Something isn't working ⚛️ Component labels Mar 1, 2023
@florentmaitre florentmaitre self-assigned this Mar 1, 2023
@florentmaitre florentmaitre mentioned this issue Mar 2, 2023
Open
1 task
florentmaitre added a commit that referenced this issue Mar 8, 2023
@florentmaitre
[#445] Fix a bug where image height is wrong in some cases in `OdsHor…
0fcb5cf 
…izontalCard`
@florentmaitre florentmaitre linked a pull request Mar 8, 2023 that will close this issue
445 - Bug - Image height is wrong in some cases in OdsHorizontalCard #461
Merged
florentmaitre added a commit that referenced this issue Mar 8, 2023
@florentmaitre
[#445] Fix a bug where image height is wrong in some cases in `OdsHor…
102b644 
…izontalCard`
florentmaitre added a commit that referenced this issue Mar 10, 2023
@florentmaitre
[#445] Fix a bug where image height is wrong in some cases in `OdsHor…
3ac3e78 
…izontalCard`
florentmaitre added a commit that referenced this issue Mar 10, 2023
@florentmaitre
[#445] Review: Remove unnecessary barriers in OdsHorizontalCard
71d4bd5
@paulinea paulinea assigned mccart77 and B3nz01d and unassigned florentmaitre Mar 13, 2023
@mccart77 mccart77 removed their assignment Mar 14, 2023
@B3nz01d B3nz01d removed their assignment Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working ⚛️ Component 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

445 - Bug - Image height is wrong in some cases in OdsHorizontalCard Orange-OpenSource/ods-android
3 participants
@florentmaitre @B3nz01d @mccart77