Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons bottom sheet & code coherence #395

Closed
B3nz01d opened this issue Jan 5, 2023 · 0 comments · Fixed by #406
Closed

Buttons bottom sheet & code coherence #395

B3nz01d opened this issue Jan 5, 2023 · 0 comments · Fixed by #406
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Jan 5, 2023

As per the sprint demo, and within the buttons component the wording between the code keywords and the customization bottom sheet should be coherent.

The "enabled" parameter should be used both in the code and in the customization bottom sheet to be coherent.
@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated 📱 demo app ⚛️ Component labels Jan 5, 2023
@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Jan 16, 2023
@paulinea paulinea self-assigned this Jan 16, 2023
paulinea added a commit that referenced this issue Jan 16, 2023
@paulinea
[#395] Use Enabled parameter in customization bottom sheets to be con…
eab0960 
…sistent with the code implementation
paulinea added a commit that referenced this issue Jan 16, 2023
@paulinea
[#395] Update changelog
ee7145b
paulinea added a commit that referenced this issue Jan 16, 2023
@paulinea
[#395] Use Enabled wording for chips customization to keep consistency
8e71ec1
@paulinea paulinea linked a pull request Jan 16, 2023 that will close this issue
395 - buttons & chips - bottom sheet wording coherence #406
Merged
paulinea added a commit that referenced this issue Jan 16, 2023
@paulinea
[#395] Review: Replace enabled checkbox customization by switch
6ecbac1
florentmaitre pushed a commit that referenced this issue Jan 16, 2023
@paulinea @florentmaitre
[#395] Use Enabled parameter in customization bottom sheets to be con…
ae669d4 
…sistent with the code implementation
florentmaitre pushed a commit that referenced this issue Jan 16, 2023
@paulinea @florentmaitre
[#395] Update changelog
d5597ca
florentmaitre pushed a commit that referenced this issue Jan 16, 2023
@paulinea @florentmaitre
[#395] Use Enabled wording for chips customization to keep consistency
70e51d7
florentmaitre pushed a commit that referenced this issue Jan 16, 2023
@paulinea @florentmaitre
[#395] Review: Replace enabled checkbox customization by switch
70460ca
florentmaitre pushed a commit that referenced this issue Jan 16, 2023
@paulinea @florentmaitre
[#395] Review: Replace enabled checkbox customization by switch
4f3a6ec
@paulinea paulinea assigned B3nz01d and unassigned paulinea Jan 17, 2023
@B3nz01d B3nz01d removed their assignment Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

395 - buttons & chips - bottom sheet wording coherence Orange-OpenSource/ods-android
2 participants
@paulinea @B3nz01d