Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the chips customization #305

Closed
B3nz01d opened this issue Oct 26, 2022 · 1 comment · Fixed by #336
Closed

Update the chips customization #305

B3nz01d opened this issue Oct 26, 2022 · 1 comment · Fixed by #336
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK Design 👌 OK PO

Comments

@B3nz01d
Copy link
Collaborator

B3nz01d commented Oct 26, 2022

The only chips design is the outline version.
Therefore the "Outline" choice should not be available anymore
@B3nz01d B3nz01d added 🧩 enhancement New feature or request 🔍 triage A new issue that needs to be treated 📱 demo app ⚛️ Component labels Oct 26, 2022
@paulinea
Copy link
Member

@B3nz01d This is the case for Orange theme but what about other themes? Today we have a Chip and an OutlinedChip component in the library, do we keep them?
Maybe we can allow a theme to choose between outlined or standard version for chips?

@paulinea paulinea removed the 🔍 triage A new issue that needs to be treated label Nov 23, 2022
paulinea added a commit that referenced this issue Nov 23, 2022
@paulinea
[#305] Remove customization for outlined chips
73533f4 
By default all chips are outlined
paulinea added a commit that referenced this issue Nov 23, 2022
@paulinea
[#305] Fix display of filter chips
79fa3bd
paulinea added a commit that referenced this issue Nov 23, 2022
@paulinea
[#305] Add chip type customization (outlined or not) in theme configu…
c8038be 
…ration
paulinea added a commit that referenced this issue Nov 23, 2022
@paulinea
[#305] Update changelog
58f788c
@paulinea paulinea linked a pull request Nov 23, 2022 that will close this issue
305 - update the chips customization #336
Merged
@paulinea paulinea assigned paulinea and unassigned B3nz01d Nov 23, 2022
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Review: Remove useless string
85f34a4
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Review: Improve contract to allow to change components default…
d085563 
… appearance
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Remove customization for outlined chips
a1521b8 
By default all chips are outlined
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Fix display of filter chips
40b7f55
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Add chip type customization (outlined or not) in theme configu…
6d72ce4 
…ration
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Update changelog
7b0de5d
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Review: Remove useless string
e6dfa29
paulinea added a commit that referenced this issue Nov 24, 2022
@paulinea
[#305] Review: Improve contract to allow to change components default…
5a0fe87 
… appearance
@paulinea paulinea assigned mccart77 and unassigned paulinea Nov 24, 2022
@B3nz01d B3nz01d removed their assignment Nov 29, 2022
@mccart77 mccart77 removed their assignment Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚛️ Component 📱 demo app 🧩 enhancement New feature or request 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

305 - update the chips customization Orange-OpenSource/ods-android
3 participants
@paulinea @B3nz01d @mccart77