Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Lists new variants #141

Closed
1 task done
mccart77 opened this issue May 4, 2022 · 3 comments · Fixed by #227
Closed
1 task done

Bug - Lists new variants #141

mccart77 opened this issue May 4, 2022 · 3 comments · Fixed by #227
Labels
🐞 bug Something isn't working ⚛️ Component 👌 OK Accessibility 👌 OK Design 👌 OK PO

Comments

@mccart77
Copy link
Collaborator

mccart77 commented May 4, 2022

Prerequisites

Your test device

Samsung Galaxy A51 5G

OS Version

Android 11

App version

v1.0 (1)

Describe the issue

Additional variants have been designed and specified and are not included in the Lists displayed. This includes single line, two line and three line lists.

Updated design reference: https://system.design.orange.com/0c1af118d/p/09a804-lists/b/669743

Expected Behavior

Lists section will include all new and updated list variants as specified in the DSM:

https://system.design.orange.com/0c1af118d/p/09a804-lists/b/669743
@mccart77 mccart77 added 🐞 bug Something isn't working 🔍 triage A new issue that needs to be treated labels May 4, 2022
@paulinea paulinea changed the title [Bug]: Lists new variants Bug - Lists new variants May 12, 2022
@B3nz01d B3nz01d removed their assignment Jun 22, 2022
@florentmaitre florentmaitre self-assigned this Jul 11, 2022
@florentmaitre
Copy link
Member

@mccart77 Should we follow this design ?https://app.zeplin.io/project/621f9736756b8eab5a1d1ca1/screen/628361a24510e4169825b9d6

florentmaitre added a commit that referenced this issue Jul 19, 2022
@florentmaitre
[#141] Update list variants UI
2252de9
florentmaitre added a commit that referenced this issue Jul 19, 2022
@florentmaitre
[#141] Rename one-line list to single-line list
4712b66
florentmaitre added a commit that referenced this issue Jul 19, 2022
@florentmaitre
[#141] Add bottom sheet to customize lists
d4f7af2
@florentmaitre florentmaitre linked a pull request Jul 19, 2022 that will close this issue
141 - bug - lists new variants #227
Merged
florentmaitre added a commit that referenced this issue Jul 20, 2022
@florentmaitre
[#141] Move lists bottom sheet to a variant screen
c5e6d8e
florentmaitre added a commit that referenced this issue Jul 20, 2022
@florentmaitre
[#141] Icon type of OdsListItem is now specified with a modifier
f0e1449
florentmaitre added a commit that referenced this issue Jul 20, 2022
@florentmaitre
[#141] Divider of OdsListItem is now displayed with a modifier
4f2995d
florentmaitre added a commit that referenced this issue Jul 20, 2022
@florentmaitre
[#141] Refactor code in lists component
52a3224
florentmaitre added a commit that referenced this issue Jul 21, 2022
@florentmaitre
[#141] Update lists README
3ac95f5
florentmaitre added a commit that referenced this issue Jul 21, 2022
@florentmaitre
[#141] Update changelog
ff055a9
florentmaitre added a commit that referenced this issue Jul 22, 2022
@florentmaitre
[#141] Divider of OdsListItem is now displayed with a modifier
ee4ac7b
florentmaitre added a commit that referenced this issue Jul 22, 2022
@florentmaitre
[#141] Refactor code in lists component
eb2a728
florentmaitre added a commit that referenced this issue Jul 22, 2022
@florentmaitre
[#141] Update lists README
1503aaf
florentmaitre added a commit that referenced this issue Jul 22, 2022
@florentmaitre
[#141] Update changelog
8b03db3
florentmaitre added a commit that referenced this issue Jul 26, 2022
@florentmaitre
[#141] Update changelog
7847a0e
florentmaitre added a commit that referenced this issue Jul 26, 2022
@florentmaitre
[#141] Rename ComponentCustomizationChipRow to ComponentChipRow
389bd62
florentmaitre added a commit that referenced this issue Aug 2, 2022
@florentmaitre
[#141] Update list variants UI
683d0fd
florentmaitre added a commit that referenced this issue Aug 2, 2022
@florentmaitre
[#141] Rename one-line list to single-line list
1092db5
@paulinea paulinea assigned B3nz01d, mccart77 and afrahB and unassigned florentmaitre Aug 4, 2022
@B3nz01d
Copy link
Collaborator

B3nz01d commented Aug 23, 2022

Identified corrections:

  • the text for the list item size needs to be updated with plural: "1 line - 2 lines - 3 lines"
  • the chips are not using the right outline formats that you can see on the other bottom sheets

@B3nz01d B3nz01d reopened this Aug 23, 2022
@B3nz01d B3nz01d assigned florentmaitre and paulinea and unassigned B3nz01d, mccart77 and afrahB Aug 23, 2022
@paulinea
Copy link
Member

New bug created for wording issue: #252
For the outlined chips, we have to wait for #169 merge

@mccart77 mccart77 removed their assignment Aug 31, 2022
@B3nz01d B3nz01d removed their assignment Aug 31, 2022
@afrahB afrahB removed their assignment Sep 8, 2022
@B3nz01d B3nz01d closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working ⚛️ Component 👌 OK Accessibility 👌 OK Design 👌 OK PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

141 - bug - lists new variants Orange-OpenSource/ods-android
5 participants
@florentmaitre @paulinea @B3nz01d @mccart77 @afrahB