Skip to content

Commit

Permalink
[#359] Review: Change "Talkback" into "TalkBack"
Browse files Browse the repository at this point in the history
  • Loading branch information
paulinea committed Mar 6, 2023
1 parent 556466c commit a3f6773
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- \[Demo\] Fix accessibility bug where content change on chip type selection was not read by Talkback ([#332](https://github.com/Orange-OpenSource/ods-android/issues/332))
- \[Demo\] Fix accessibility bug where text fields error messages were not read by Talkback on state change ([#359](https://github.com/Orange-OpenSource/ods-android/issues/359))
- \[Lib\] Implement workaround by adding content description to `OdsOutlinedTextField` in order to allow Talkback to focus this type of text field ([#359](https://github.com/Orange-OpenSource/ods-android/issues/359))
- \[Demo\] Fix accessibility bug where content change on chip type selection was not read by TalkBack ([#332](https://github.com/Orange-OpenSource/ods-android/issues/332))
- \[Demo\] Fix accessibility bug where text fields error messages were not read by TalkBack on state change ([#359](https://github.com/Orange-OpenSource/ods-android/issues/359))
- \[Lib\] Implement workaround by adding content description to `OdsOutlinedTextField` in order to allow TalkBack to focus this type of text field ([#359](https://github.com/Orange-OpenSource/ods-android/issues/359))

## [0.11.0](https://github.com/Orange-OpenSource/ods-android/compare/0.10.0...0.11.0) - 2023-03-03

Expand All @@ -33,7 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- \[Demo\] Update application name and description in about page ([#419](https://github.com/Orange-OpenSource/ods-android/issues/419))
- \[Demo\] Fix accessibility bug by preventing Talkback to read the linear progress value twice ([#441](https://github.com/Orange-OpenSource/ods-android/issues/441))
- \[Demo\] Fix accessibility bug by preventing TalkBack to read the linear progress value twice ([#441](https://github.com/Orange-OpenSource/ods-android/issues/441))
- \[Demo\] Keep same bottom sheet height when content or not ([#447](https://github.com/Orange-OpenSource/ods-android/issues/447))

## [0.10.0](https://github.com/Orange-OpenSource/ods-android/compare/0.9.0...0.10.0) - 2023-02-07
Expand All @@ -58,7 +58,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- \[Demo\] In buttons screens, group lines of code into one vocalisation ([#392](https://github.com/Orange-OpenSource/ods-android/issues/392))
- \[Demo\] Fix an accessibility bug where icon buttons were not focusable with Talkback ([#393](https://github.com/Orange-OpenSource/ods-android/issues/393))
- \[Demo\] Fix an accessibility bug where icon buttons were not focusable with TalkBack ([#393](https://github.com/Orange-OpenSource/ods-android/issues/393))
- \[Demo\] Fix list item selection controls trailing vocalization: Checkboxes, Switches and Radio Buttons in lists ([#387](https://github.com/Orange-OpenSource/ods-android/issues/387))
- \[Demo\] Screens in about section now use current theme colors ([#390](https://github.com/Orange-OpenSource/ods-android/issues/390))
- \[Demo\] Fix crash when exiting the fixed tabs screen ([#418](https://github.com/Orange-OpenSource/ods-android/issues/418))
Expand Down
2 changes: 1 addition & 1 deletion docs/components/NavigationBottom.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ Here is an example:
OdsBottomNavigation {
for (item in navigationItems) {
OdsBottomNavigationItem(
icon = { Icon(painter = painterResource(id = item.iconResId), contentDescription = null) }, // contentDescription is null cause Talkback already read the item's title
icon = { Icon(painter = painterResource(id = item.iconResId), contentDescription = null) }, // contentDescription is null cause TalkBack already read the item's title
label = stringResource(id = item.titleResId),
selected = selectedItem.value.titleResId == item.titleResId,
onClick = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ fun OdsLinearProgressIndicator(
modifier = Modifier
.padding(top = dimensionResource(id = R.dimen.spacing_xs))
.semantics {
this.invisibleToUser() // Prevent Talkback to focus this Text cause the value of the progress is already read on LinearProgressIndicator focus
this.invisibleToUser() // Prevent TalkBack to focus this Text cause the value of the progress is already read on LinearProgressIndicator focus
},
text = String.format(stringResource(id = R.string.progress_linear_indicator_value), (progress * 100).toInt())
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ internal fun OdsOutlinedTextField(
},
modifier = modifier.semantics {
contentDescription =
label.orElse { "Text field" } // TODO Remove it when switching to Compose 1.4.0 which is supposed to fix the problem of OutlinedTextField Talkback focus: https://issuetracker.google.com/issues/251162419
label.orElse { "Text field" } // TODO Remove it when switching to Compose 1.4.0 which is supposed to fix the problem of OutlinedTextField TalkBack focus: https://issuetracker.google.com/issues/251162419
},
enabled = enabled,
readOnly = readOnly,
Expand Down

0 comments on commit a3f6773

Please sign in to comment.