Merge pull request #711 from Orange-OpenSource/710-bug-odspasswordtex…

…tfield-sizing-or-positioning-constraints-are-not-honored 710 - Fix OdsPasswordTextField sizing or positioning
Orange-OpenSource · Nov 27, 2023 · 1bf4ab2 · 1bf4ab2
2 parents 9beec81 + 474177a
commit 1bf4ab2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/changelog.md b/changelog.md
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - \[App\] Fix nested class names in code implementation ([#708](https://github.com/Orange-OpenSource/ods-android/issues/708))
 - \[Lib\] Fix back button color in `OdsLargeTopAppBar` ([#685](https://github.com/Orange-OpenSource/ods-android/issues/685))
+- \[Lib\] Fix a bug where the modifier was not taken into account in `OdsPasswordTextField` ([#710](https://github.com/Orange-OpenSource/ods-android/issues/710))
 
 ## [0.17.0](https://github.com/Orange-OpenSource/ods-android/compare/0.16.0...0.17.0) - 2023-11-06
 

diff --git a/...src/main/java/com/orange/ods/compose/component/textfield/password/OdsPasswordTextField.kt b/...src/main/java/com/orange/ods/compose/component/textfield/password/OdsPasswordTextField.kt
@@ -11,6 +11,7 @@
 package com.orange.ods.compose.component.textfield.password
 
 import androidx.compose.foundation.layout.Column
+import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.text.KeyboardActions
 import androidx.compose.foundation.text.KeyboardOptions
 import androidx.compose.material.Text
@@ -85,11 +86,11 @@ fun OdsPasswordTextField(
         this.visualisationIcon.value = visualisationIcon
     }
 
-    Column {
+    Column(modifier = modifier) {
         OdsTextField(
             value = value,
             onValueChange = onValueChange,
-            modifier = modifier,
+            modifier = Modifier.fillMaxWidth(),
             enabled = enabled,
             readOnly = readOnly,
             label = label,