-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add cards RTL example #1603
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 2.5%, saving 2.58 KB.
59 images did not require optimisation. Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions. |
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 thing to tackle before approval!
<h6 class="card-text">شرح</h6> | ||
</div> | ||
<div class="card-footer bg-dark text-light pt-2"> | ||
<a class="btn btn-secondary" aria-label="وصف الزر" title="وصف الزر">زر</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some display are weird in GitHub but they looks good in the file in VSCode 🤔I need to check if there's an issue inside GitHub referencing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page rendering is OK in the browsers. The text is well-displayed in the IDE as well. So yeah, it must be an issue on GitHub side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This comment was marked as resolved.
This comment was marked as resolved.
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related issues
closes #1549
Description
Motivation & Context
Need of an RTL example
Types of change
Live previews
Checklist
npm run lint
)