Feature/static code security scanner #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmarsh
commented
Feb 18, 2020
| #fi | ||
| #echo "done." | ||
|
|
||
| #echo -n "Linting golang code... " |
There was a problem hiding this comment.
I want to enable formatting/linting in a separate PR since it will likely be a large diff that doesn't change any functionality.
…-code-security-scanner
joshmarsh
commented
Feb 18, 2020
| @@ -70,6 +70,9 @@ type DeleteLeasesIDOK struct { | |||
| } | |||
|
|
|||
| func (o *DeleteLeasesIDOK) Error() string { | |||
| /* | |||
| #nosec: CWE-89 false positive. No sql here. | |||
There was a problem hiding this comment.
#nosec is the syntax for annotating known gosec issues so that they don't cause the tool to fail.
joshmarsh
changed the title
joshmarsh
requested review from
nathanagood,
eschwartz,
AmudaPalani,
kddejong and
marinatedpork
eschwartz
reviewed
Feb 19, 2020
| @@ -40,6 +43,9 @@ func (u *AWSUtil) UploadDirectoryToS3(localPath string, bucket string, prefix st | |||
| if err != nil { | |||
| log.Fatalln("Unable to get relative path:", path, err) | |||
| } | |||
| /* | |||
| #nosec CWE-22: added disclaimer to function docs | |||
There was a problem hiding this comment.
@joshmarsh can you explain how this works / what is does?
There was a problem hiding this comment.
Sorry, I though I added a comment explaining nosec, but I’m not seeing it anymore.
Adding a //#nosec comment causes gosec to skip the code that you commented.
Here are the docs: https://github.com/securego/gosec/blob/master/README.md#annotating-code
eschwartz
reviewed
Feb 19, 2020
eschwartz
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
gosec is a static code analysis tool that scans for known security vulnerabilities. This PR adds gosec to the pipeline and fixes some issues raised by the tool.
Example of gosec working in our pipeline
Types of changes
Checklist
README.md, inline comments, etc.)CHANGELOG.mdunder a## nextrelease, with a short summary of my changesRelevant Links
Further comments