Regenerate swagger client from DCE master #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resulted in generated code not getting updated, after swagger changes
eschwartz
commented
Feb 14, 2020
| @@ -5,8 +5,9 @@ all: mocks test build | |||
| # Generate client code from swagger in a local dce repo (make openapi DCE_REPO=/path/to/dce) | |||
| openapi: | |||
| echo "\nMANUAL STEP: Install goswagger cli tool if needed: https://goswagger.io/install.html\n" | |||
| swagger flatten --with-expand $(DCE_REPO)/modules/swagger.yaml >> $(PWD)/out.yaml | |||
| swagger flatten --with-expand $(DCE_REPO)/modules/swagger.yaml > $(PWD)/out.yaml | |||
There was a problem hiding this comment.
This >> redirect was actually causing the code generation to fail
9 tasks
marinatedpork
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Regenerate the swagger client from the latest DCE master (commit f6bb5ba)
Context: I'd like to open a PR to support some new DCE features, which require that I regenerate the client. But regenerating changes a lot of lines of code, so I'd prefer it in a separate PR.
I ran:
make openapi DCE_REPO=/path/to/my/local/repo/at/mastermake ifacesmake mocksI had to make a couple manual tweaks on top of that, to get go compiling, but very minor.