Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): remove dependency on hikariCP #85

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

jcornaz
Copy link
Contributor

@jcornaz jcornaz commented Nov 19, 2024

The purpose of Hikari is to manage a connection pool. But as we only need a single (and ephemeral) connection to the database, I suggest we remove that dependency.

Copy link
Collaborator

@ursjoss ursjoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, IMHO. The DB access we're changing here is only used for the generation of the DB scheme as type safe classes, not how the applications managed with jooq-gradle operate their own DB connection, right?

@jcornaz
Copy link
Contributor Author

jcornaz commented Nov 19, 2024

The DB access we're changing here is only used for the generation of the DB scheme as type safe classes, not how the applications managed with jooq-gradle operate their own DB connection, right?

Yes, that's right.

@jcornaz jcornaz merged commit 4ee375f into main Nov 19, 2024
4 checks passed
@jcornaz jcornaz deleted the remove-hikari-dependency branch November 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants