Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preselecting existing model value for enum #78

Open
kkankala opened this issue Mar 31, 2016 · 6 comments
Open

Preselecting existing model value for enum #78

kkankala opened this issue Mar 31, 2016 · 6 comments
Labels

Comments

@kkankala
Copy link

enum is not calling for $scope.finalizeTitleMap(form, form.titleMap, form.options); in $scope.populateTitleMap.

@nicklasb
Copy link
Member

You are right, that is a bug. Will you make a PR or should I put it on the todo-list?

@nicklasb nicklasb added the bug label Mar 31, 2016
@kkankala
Copy link
Author

kkankala commented Apr 1, 2016

I would really like to fix it. I have never done PR, when i clicked on PR it is pointing to base fork angular strap select. not sure if that is correct. let me know.

@nicklasb
Copy link
Member

nicklasb commented Apr 1, 2016

First you create a fork of ASFDS of your own to play around with until you are satisfied:
https://help.github.com/articles/fork-a-repo/

Then based on the changes you made, you make a pull request:
https://help.github.com/articles/using-pull-requests/

Try to only include only one fix in each PR (it may concern several files)

I can then choose to accept (or not) that request, adding it to my repo.
You will be credited as a committer in the log.

It is really simple, once you've gotten used to it (as with everything else, sorry 'bout the cliché..).

@kkankala
Copy link
Author

kkankala commented Apr 1, 2016

Okay thanks.

@nicklasb
Copy link
Member

Have you had any opportunity to do anything about this?

@kkankala
Copy link
Author

kkankala commented Jan 1, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants