[Enhancement] Add provision to skip TLS validation (#1)

.github/workflows/integration.yml

@@ -2,30 +2,21 @@ name: Integration Test
 
 on:
   push:
+    branches: [ main ]
 
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
 
-      - name: Import Secrets
-        id: secrets
-        uses: hashicorp/[email protected]
-        with:
-          url: ${{ secrets.VAULT_ADDR }}
-          method: github
-          githubToken: ${{ secrets.GT_VAULT_AUTH_TOKEN }}
-          secrets: |
-            argocd/data/token admin | ARGOCD_TOKEN ;
-
       - name: Self test
         id: selftest
         uses: ./
         with:
-          address: ${{ secrets.ARGOCD_ADDR }}
-          token: ${{ steps.secrets.outputs.ARGOCD_TOKEN }}
+          address: ${{ secrets.ARGOCD_SERVER }}
+          token: ${{ secrets.ARGOCD_TOKEN }}
           action: sync
-          appName: argocd-apps
+          appName: ${{ secrets.ARGOCD_APP_NAME }}
           image: latest
-
+          disableTlsVerification: "false"

README.md

@@ -25,16 +25,18 @@ jobs:
           token: ${{ secrets.ARGOCD_TOKEN }}
           action: sync
           appName: "my-example-app"
+          disableTlsVerification: "false" # Default is false. Only enable this if ArgoCD doesn't have TLS / has self signed certificate / you see any sort of x509 errors
 ```
 
 ### Inputs
 
-| Input     | Description                            |
-|-----------|----------------------------------------|
-| `address` | ArgoCD server address.                 |
-| `token`   | ArgoCD Token.                          |
-| `action`  | ArgoCD Action i.e. sync.               |
-| `appName` | Application name to execute action on. |
+| Input                    | Description                            |
+|--------------------------|----------------------------------------|
+| `address`                | ArgoCD server address.                 |
+| `token`                  | ArgoCD Token.                          |
+| `action`                 | ArgoCD Action i.e. sync.               |
+| `appName`                | Application name to execute action on. |
+| `disableTlsVerification` | Skip TLS validation.                   |
 
 ## Examples
 
@@ -57,4 +59,5 @@ jobs:
           token: ${{ secrets.ARGOCD_TOKEN }}
           action: sync
           appName: "my-example-app"
+          disableTlsVerification: "false" # Default is false. Only enable this if ArgoCD doesn't have TLS / has self signed certificate / you see any sort of x509 errors
 ```

action.yml

@@ -22,17 +22,22 @@ inputs:
   image:
     description: "Image tag for the binary"
     required: false
-    default: "latest"
+    default: "latest"  
+  disableTlsVerification:
+    description: "Disable TLS Verification"
+    required: true
+    default: "false"
 
 runs:
   using: "composite"
   steps:
     - name: Run argocd-actions CLI from the image for GH image registry
       run: |
-        docker run --rm -i ghcr.io/omegion/argocd-actions:${{ inputs.image }} \
+        docker run --rm -i registry.devopsnow.io/public/argocd-sync-action:${{ inputs.image }} \
           ${{ inputs.action }} \
           --application=${{ inputs.appName }} \
           --token=${{ inputs.token }} \
           --address=${{ inputs.address }} \
+          --disableTlsVerification=${{disableTlsVerification}} \
           --logLevel=debug
       shell: sh

cmd/root.go

@@ -27,5 +27,11 @@ func Root() *cobra.Command {
 		log.Fatalf("Lethal damage: %s\n\n", err)
 	}
 
+	cmd.PersistentFlags().String("disableTlsVerification", "", "Disable TLS verification")
+
+	if err := cmd.MarkPersistentFlagRequired("disableTlsVerification"); err != nil {
+		log.Fatalf("Lethal damage: %s\n\n", err)
+	}
+
 	return cmd
 }

cmd/sync.go

@@ -1,6 +1,8 @@
 package cmd
 
 import (
+	"strconv"
+
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
 
@@ -17,10 +19,13 @@ func Sync() *cobra.Command {
 			address, _ := cmd.Flags().GetString("address")
 			token, _ := cmd.Flags().GetString("token")
 			application, _ := cmd.Flags().GetString("application")
+			disableTlsVerification, _ := cmd.Flags().GetString("disableTlsVerification")
+			disableTlsVerificationBool, _ := strconv.ParseBool(disableTlsVerification)
 
 			api := argocd.NewAPI(&argocd.APIOptions{
-				Address: address,
-				Token:   token,
+				Address:                address,
+				Token:                  token,
+				DisableTlsVerification: disableTlsVerificationBool,
 			})
 
 			controller := ctrl.NewController(api)

internal/argocd/api.go

@@ -3,14 +3,16 @@ package argocd
 import (
 	"context"
 	"io"
+	"log"
 
 	argocdclient "github.com/argoproj/argo-cd/v2/pkg/apiclient"
 	applicationpkg "github.com/argoproj/argo-cd/v2/pkg/apiclient/application"
 	argoio "github.com/argoproj/argo-cd/v2/util/io"
 )
 
-//nolint:lll // go generate is ugly.
 // Interface is an interface for API.
+//
+//nolint:lll // go generate is ugly.
 type Interface interface {
 	Sync(appName string) error
 }
@@ -23,8 +25,9 @@ type API struct {
 
 // APIOptions is options for API.
 type APIOptions struct {
-	Address string
-	Token   string
+	Address                string
+	Token                  string
+	DisableTlsVerification bool
 }
 
 // NewAPI creates new API.
@@ -33,9 +36,13 @@ func NewAPI(options *APIOptions) API {
 		ServerAddr: options.Address,
 		AuthToken:  options.Token,
 		GRPCWeb:    true,
+		Insecure:   options.DisableTlsVerification,
 	}
 
 	connection, client := argocdclient.NewClientOrDie(&clientOptions).NewApplicationClientOrDie()
+	if options.DisableTlsVerification {
+		log.Println("Skip TLS Validation option is enabled")
+	}
 
 	return API{client: client, connection: connection}
 }