Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-22069: Created a local HttpMethod ENUM as the one coming from spring is not serialisable trough ObjectMapper #47

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

rahul-chekuri
Copy link
Collaborator

@rahul-chekuri rahul-chekuri commented Jun 17, 2024

https://devopsmx.atlassian.net/browse/OP-22069

As part of CVE fixes, spring-web has been upgraded. In the new package, HttpMethod is converted to a class from Enum. Due to this change, ObjectMapper cannot serialize @org.springframework.http.HttpMethod, so we created this Enum to support serialization.

Root Cause: As part of CVE fixes we have upgraded the spring version. The newer version has HttpMethod as a Class instead of an Enum. This leads to serialisation issues.

Solution: Create a local copy of the old Enum HttpMethod and use it wherever required.

@rahul-chekuri rahul-chekuri changed the title OP-22069: disabled FAIL_ON_EMPTY_BEANS. OP-22069: Created a local HttpMethod ENUM as the one coming from spring is not serialisable trough ObjectMapper Jun 21, 2024
Copy link
Collaborator

@sanopsmx sanopsmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanopsmx sanopsmx merged commit c35b58f into OES-1.30.1 Jun 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants