Resolving minor issues #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Project Jira : NA
Project Doc : NA
Parts of this PR :
Why removed "com.nhaarman.mockito_kotlin.verifyZeroInteractions"
-> verifyZeroInteractions internally calls Mockito.verifyZeroInteractions, but verifyZeroInteractions() was removed from Mockito4 ref, instead it sugggest to use Mockito.NoInteraction() and that is already used.
So, it is unused import statement, removal of it will not cause any impact.
Uncommenting commented testcase.
Older original code uses com.nhaarman:mockito-kotlin v1.6.0, there is no point to use older version.
v1.6.0 is coming from kork-bom
How changes are verified
No impact on compile and testcase
Documentation Updates
Do we need to update dashboards? No
Do we need to update SOP, new hire wiki or other documents? No
Rollback, Deployment Details
Can this change be rolled back automatically without any issue? Yes
Is this a backwards-compatible change in your opinion ? Yes
Pre deployment steps : NA
Post deployment steps : NA