Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issues in plugin #216

Merged
merged 3 commits into from
Apr 6, 2019

Conversation

bmwsedee
Copy link
Contributor

@bmwsedee bmwsedee commented Jan 3, 2019

As also stated in #195 I noticed that the plugin had some performance issues, especially in larger multi-repository projects where all repositories make use of gitflow.

I made a number of improvements (at least I think they're improvements, but you'll have to agree of course):

  1. Caching the already-retrieved branches. Since the plugin updates the GitflowBranchUtil on every git-change anyway, these don't change anyway, so caching them locally saves some time
  2. Caching the prefixes found using the GitflowConfigUtil when figuring out if gitflow is even used in the project. This turned out to save a lot of time, as parsing the config-file apparently takes relatively long
  3. Creating the actual actions only once and have the actions themselves figure out if they need to be shown or not.

When you get to merging this I'll probably have to look into #214 again as well, since the menu-options also make use of the RepoActions-class and determining whether or not to show the "Advanced"-options should probably be handled differently. Or the other way around of course, depending on which you want to merge first.
Let me know what you think! :-)

@OpherV
Copy link
Owner

OpherV commented Jan 8, 2019

This is great! Thanks!
I'll probably wrap up reviewing and merging #214 and then this one

@avatarkava avatarkava mentioned this pull request Feb 24, 2019
3 tasks
@avatarkava
Copy link

@OpherV are there any remaining tasks on this or just waiting til you have a bit of time to complete testing/merging?

@OpherV
Copy link
Owner

OpherV commented Mar 3, 2019

@avatarkava It's just a matter of time unfortunately. I feel really bad for delaying so much with @bmwsedee 's great work but I've been swamped with personal life stuff and work so hoping to get to it soon.

@OpherV OpherV merged commit b3a7f2b into OpherV:develop Apr 6, 2019
@OpherV
Copy link
Owner

OpherV commented Apr 6, 2019

@bmwsedee Great job! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants