Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add 2019.2 support #241

Closed
BlackRule opened this issue Jul 15, 2019 · 21 comments
Closed

Please add 2019.2 support #241

BlackRule opened this issue Jul 15, 2019 · 21 comments

Comments

@BlackRule
Copy link

No description provided.

@UkonnRa
Copy link

UkonnRa commented Jul 25, 2019

You can just clone the project and change untilBuild to 192.*. I have just done some update but could not push it as a new branch. Any idea? @OpherV

@gsolecki
Copy link

I would like to join to the request.

@r-da
Copy link

r-da commented Jul 26, 2019

Yes please update the plugin

@artemsky
Copy link

artemsky commented Jul 26, 2019

Can't w8, tmply using this hack #221 (comment)

@r-da
Copy link

r-da commented Jul 26, 2019

If you can't wait (like me) here is a workarund that apparently works:

  1. find gitflow4idea-0.6.8.jar
    • on linux for 2019.1 users the path is $HOME/.PhpStorm2019.1/config/plugins/gitflow4idea/lib/gitflow4idea-0.6.8.jar.
    • on linux for 2019.2 users the path is $HOME/.PhpStorm2019.2/config/plugins/gitflow4idea/lib/gitflow4idea-0.6.8.jar
  2. modify the META-INF/plugin.xml file inside the jar, changing until-build="191.*" to until-build="192.*"

Now you can use the plugin under 2019.2 and it seems to work correctly.

To modify the jar you can unpack it and then pack it again or use vim:

  1. open the jar with vim
  2. find the line META-INF/plugin.xml
  3. press enter
  4. change the until-build as above
  5. type :wq! and then :q!

@palanza
Copy link

palanza commented Jul 26, 2019

+1

@jayesh-bhadja
Copy link

Yes please update the plugin

@diesl
Copy link

diesl commented Aug 1, 2019

See also #200 for the general aspect of this issue

@OpherV
Copy link
Owner

OpherV commented Aug 4, 2019

I'm aware of this and a new version will be coming. I haven't had the time yet to sort out and properly test the 2019.2 issues. You're welcome to follow @r-da's suggestion but keep in mind this is untested. Testing is important, you don't want weird intellij bugs messing up your repos.

@FlashGen
Copy link

FlashGen commented Aug 6, 2019

Apologies if OT, but any chance of AppCode support at the same time?

@krotoveugene
Copy link

krotoveugene commented Aug 7, 2019

Hey guys, anyone knows how to install (from scratch) a current version of the plugin on 2019.2 IDEA?

@r-da
Copy link

r-da commented Aug 7, 2019

  1. Download the 0.6.8 release here
  2. Apply the changes described here
  3. Install it manually into IDEA
  4. Remember the caveat by OpherV

@krotoveugene
Copy link

  1. Download the 0.6.8 release here
  2. Apply the changes described here
  3. Install it manually into IDEA
  4. Remember the caveat by OpherV

When I try to install the plugin, I've got an error: Fail to load plugin descriptor from file gitflow4idea-0.6.8.jar

@vrobre
Copy link

vrobre commented Aug 11, 2019

Is it know when this might be compatile with 2019.2?
It would be great to have this back.

@krotoveugene
Copy link

Hey guys, I've just found out a solution that works for me (2019.2 version):

  1. Clone project (develop branch)
  2. Edit build.gradle file - change param untilBuild to 192.*
    untilBuild '191.*'
  3. Run in IntelliJ IDEA: Gradle -> Tasks -> build -> jar
  4. Install plugin from disk

@bbakermmc
Copy link

@krotoveugene Can you just post the built jar file, would save people the hassle of getting everything needed to build it.

@krotoveugene
Copy link

gitflow4idea-0.6.8.zip

Rename to gitflow4idea-0.6.8.jar

@DiesIrae
Copy link

Thanks @krotoveugene! Much appreciated :-)

@lucacri
Copy link

lucacri commented Aug 21, 2019

@krotoveugene thank you so much! Hopefully the PR gets merged soon also!

@OpherV
Copy link
Owner

OpherV commented Aug 22, 2019

Btw this PR is superficial and doesn't address the issue of actions running as synchronous execution on EDT, which I'm working to sort out before we have true 2019.2 support

@OpherV
Copy link
Owner

OpherV commented Aug 22, 2019

Version 0.6.9 is now on the Jetbrains Repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests